From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id C31263896815; Thu, 25 Feb 2021 21:46:30 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C31263896815
From: "roland.illig at gmx dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/99275] New: missing space in 'argument missing terminating nul'
Date: Thu, 25 Feb 2021 21:46:30 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: roland.illig at gmx dot de
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-99275-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Feb 2021 21:46:30 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99275

            Bug ID: 99275
           Summary: missing space in 'argument missing terminating nul'
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: roland.illig at gmx dot de
  Target Milestone: ---

builtins.c says:
> warned =3D warning_at (loc, OPT_Wstringop_overread,
>                      "%qsargument missing terminating nul",
>                      fname);

This confused me as the German translator.

First, I thought that fname was a filename, which didn't make sense at all.=
 It
took me some minutes to find out that fname was supposed to be the function
name, I would have expected fnname for that.

Then I wondered why there is no space between %qs and 'argument'.

Then I wondered how this missing space could have passed the test suite, as=
 the
test suite does contain several instances of dg-message for this diagnostic.
The tricky point here is that there are two diagnostics that are almost the
same, the other one uses %qD instead of %qs.

A possible explanation for missing the missing space is that to avoid to te=
st
the varying quotes, that part of the diagnostic is generally not tested. But
shouldn't the quotes in LC_ALL=3DC always be simple ASCII quotes, making th=
is
simple?

While here, there's a typo in a comment in warn_string_no_nul: "the nuber of
messages" should be "the number of messages".=