public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/99283] [modules] ICE in assert_definition, at cp/module.cc:4608 Date: Fri, 26 Mar 2021 19:08:48 +0000 [thread overview] Message-ID: <bug-99283-4-hlIRRB2BSt@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99283-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99283 --- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Nathan Sidwell <nathan@gcc.gnu.org>: https://gcc.gnu.org/g:d82797420c2238e31a7a25fe6db6bd05cd37224d commit r11-7866-gd82797420c2238e31a7a25fe6db6bd05cd37224d Author: Nathan Sidwell <nathan@acm.org> Date: Fri Mar 26 10:46:31 2021 -0700 c++: imported templates and alias-template changes [PR 99283] During development of modules, I had difficulty deciding whether the module flags of a template should live on the decl_template_result, the template_decl, or both. I chose the latter, and require them to be consistent. This and a few other defects show how hard that consistency is. Hence this patch move to holding the flags on the template-decl-result decl. That's the entity various bits of the parser have at the appropriate time. Once needs STRIP_TEMPLATE in a bunch of places, which this patch adds. Also a check that we never give a TEMPLATE_DECL to the module flag accessors. This left a problem with how I was handling template aliases. These were in two parts -- separating the TEMPLATE_DECL from the TYPE_DECL. That seemed somewhat funky, but development showed it necessary. Of course, that causes problems if the TEMPLATE_DECL cannot contain 'am imported' information. Investigating now shows that we do not need to treat them separately. By reverting a bit of template instantiation machinery that caused the problem, we're back on course. I think what has happened is that between then and now, other typedef fixes have corrected the underlying problem this separation was working around. It allows a bunch of cleanup in the decl streamer, as we no longer have to handle a null TEMPLATE_DECL_RESULT. PR c++/99283 gcc/cp/ * cp-tree.h (DECL_MODULE_CHECK): Ban TEMPLATE_DECL. (SET_TYPE_TEMPLATE_INFO): Restore Alias template setting. * decl.c (duplicate_decls): Remove template_decl module flag propagation. * module.cc (merge_kind_name): Add alias tmpl spec as a thing. (dumper::impl::nested_name): Adjust for template-decl module flag change. (trees_in::assert_definition): Likewise. (trees_in::install_entity): Likewise. (trees_out::decl_value): Likewise. Remove alias template separation of template and type_decl. (trees_in::decl_value): Likewise. (trees_out::key_mergeable): Likewise, (trees_in::key_mergeable): Likewise. (trees_out::decl_node): Adjust for template-decl module flag change. (depset::hash::make_dependency): Likewise. (get_originating_module, module_may_redeclare): Likewise. (set_instantiating_module, set_defining_module): Likewise. * name-lookup.c (name_lookup::search_adl): Likewise. (do_pushdecl): Likewise. * pt.c (build_template_decl): Likewise. (lookup_template_class_1): Remove special alias_template handling of DECL_TI_TEMPLATE. (tsubst_template_decl): Likewise. gcc/testsuite/ * g++.dg/modules/pr99283-2_a.H: New. * g++.dg/modules/pr99283-2_b.H: New. * g++.dg/modules/pr99283-2_c.H: New. * g++.dg/modules/pr99283-3_a.H: New. * g++.dg/modules/pr99283-3_b.H: New. * g++.dg/modules/pr99283-4.H: New. * g++.dg/modules/tpl-alias-1_a.H: Adjust scans. * g++.dg/modules/tpl-alias-1_b.C: Adjust scans.
next prev parent reply other threads:[~2021-03-26 19:08 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-26 8:51 [Bug c++/99283] New: " alexander.lelyakin at googlemail dot com 2021-03-05 21:06 ` [Bug c++/99283] " nathan at gcc dot gnu.org 2021-03-05 21:44 ` alexander.lelyakin at googlemail dot com 2021-03-05 23:09 ` alexander.lelyakin at googlemail dot com 2021-03-06 7:45 ` alexander.lelyakin at googlemail dot com 2021-03-13 7:07 ` alexander.lelyakin at googlemail dot com 2021-03-23 19:29 ` cvs-commit at gcc dot gnu.org 2021-03-23 19:30 ` nathan at gcc dot gnu.org 2021-03-24 6:41 ` alexander.lelyakin at googlemail dot com 2021-03-24 19:46 ` alexander.lelyakin at googlemail dot com 2021-03-26 19:08 ` cvs-commit at gcc dot gnu.org [this message] 2021-03-26 19:09 ` nathan at gcc dot gnu.org 2021-03-27 6:27 ` alexander.lelyakin at googlemail dot com 2021-03-27 18:29 ` alexander.lelyakin at googlemail dot com 2021-03-30 16:52 ` cvs-commit at gcc dot gnu.org 2021-03-30 16:53 ` nathan at gcc dot gnu.org 2021-03-30 20:01 ` alexander.lelyakin at googlemail dot com 2021-04-01 12:37 ` cvs-commit at gcc dot gnu.org 2021-04-01 12:38 ` nathan at gcc dot gnu.org 2021-04-01 12:39 ` nathan at gcc dot gnu.org 2021-04-01 12:56 ` alexander.lelyakin at googlemail dot com 2021-04-01 13:40 ` nathan at gcc dot gnu.org 2021-04-01 13:43 ` alexander.lelyakin at googlemail dot com 2021-04-02 16:09 ` nathan at gcc dot gnu.org 2021-04-02 17:16 ` alexander.lelyakin at googlemail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99283-4-hlIRRB2BSt@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).