public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/99318] [10/11 Regression] -Wdeprecated-declarations where non-should be?
Date: Tue, 23 Mar 2021 14:56:29 +0000	[thread overview]
Message-ID: <bug-99318-4-SqAk6wa6g7@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99318-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99318

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:

https://gcc.gnu.org/g:831f9f768eb1fbf9a31d9a89591188b1487b6376

commit r11-7789-g831f9f768eb1fbf9a31d9a89591188b1487b6376
Author: Marek Polacek <polacek@redhat.com>
Date:   Tue Mar 9 19:23:48 2021 -0500

    c++: Fix bogus warning in deprecated namespace [PR99318]

    In GCC 10, I introduced cp_warn_deprecated_use_scopes so that we can
    handle attribute deprecated on a namespace declaration.  This
    function walks the decl's contexts so that we warn for code like

      namespace [[deprecated]] N { struct S { }; }
      N::S s;

    We call cp_warn_deprecated_use_scopes when we encounter a TYPE_DECL.
    But in the following testcase we have a TYPE_DECL whose context is
    a deprecated function; that itself is not a reason to warn.  This
    patch limits for which entities we call cp_warn_deprecated_use;
    essentially it's what can follow ::.

    I noticed that we didn't test that

      struct [[deprecated]] S { static void fn(); };
      S::fn();

    produces the expected warning, so I've added gen-attrs-73.C.

    gcc/cp/ChangeLog:

            PR c++/99318
            * decl2.c (cp_warn_deprecated_use_scopes): Only call
            cp_warn_deprecated_use when decl is a namespace, class, or enum.

    gcc/testsuite/ChangeLog:

            PR c++/99318
            * g++.dg/cpp0x/attributes-namespace6.C: New test.
            * g++.dg/cpp0x/gen-attrs-73.C: New test.

  parent reply	other threads:[~2021-03-23 14:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-01 14:48 [Bug c++/99318] New: " gcc-bugs at marehr dot dialup.fu-berlin.de
2021-03-02  7:32 ` [Bug c++/99318] " rguenth at gcc dot gnu.org
2021-03-09 13:49 ` jakub at gcc dot gnu.org
2021-03-09 14:21 ` mpolacek at gcc dot gnu.org
2021-03-23 14:56 ` cvs-commit at gcc dot gnu.org [this message]
2021-03-23 14:58 ` [Bug c++/99318] [10 " mpolacek at gcc dot gnu.org
2021-03-29 12:38 ` cvs-commit at gcc dot gnu.org
2021-03-29 12:38 ` rguenth at gcc dot gnu.org
2021-08-11 20:57 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99318-4-SqAk6wa6g7@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).