public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/99326] [9/10/11 Regression] ICE in gfc_build_dummy_array_decl, at fortran/trans-decl.c:1299
Date: Tue, 02 Mar 2021 11:39:02 +0000	[thread overview]
Message-ID: <bug-99326-4-rzi1a7SXzO@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99326-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99326

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
This looks very much like an error I looked at before.
I think that was for 'select rank (y => x)', which
has the same issue as 'select type (y => x)' or
as this PR shows 'associate (y=>x)'.


Additionally, the following points to the 'x' (gfc_current_location)
and not to 'y'; we should save that location for the error message:

11 |       associate (y => x)
   |                       1
Error: Assumed shape array at (1) must be a dummy argument

That's something we should fix in match.c, where we have:
      if (gfc_match (" %n =>", newAssoc->name) != MATCH_YES)
...
      if (gfc_match (" %e", &newAssoc->target) 
...
      newAssoc->where = gfc_current_locus;

for associate but likewise for select type/rank.

 * * * 

In resolve.c, there is:
      if (((as->type == AS_ASSUMED_SIZE && !as->cp_was_assumed)
           || as->type == AS_ASSUMED_SHAPE)
          && !sym->attr.dummy && !sym->attr.select_type_temporary)

the latter is set for both select type + select rank. Looks as if we also need
a check like:
   sym->assoc
or something like that.

We probably should audit all code which uses select_type_temporary or
sym->assoc to see whether we need to add a condition for associate or select
type/rank there as well.

  parent reply	other threads:[~2021-03-02 11:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-01 17:09 [Bug fortran/99326] New: " gscfq@t-online.de
2021-03-02  7:44 ` [Bug fortran/99326] " rguenth at gcc dot gnu.org
2021-03-02  9:53 ` marxin at gcc dot gnu.org
2021-03-02 11:39 ` burnus at gcc dot gnu.org [this message]
2021-06-01  8:19 ` [Bug fortran/99326] [9/10/11/12 " rguenth at gcc dot gnu.org
2022-05-27  9:44 ` [Bug fortran/99326] [10/11/12/13 " rguenth at gcc dot gnu.org
2022-06-28 10:43 ` jakub at gcc dot gnu.org
2023-06-02  7:42 ` [Bug fortran/99326] [10/11/12/13/14 " cvs-commit at gcc dot gnu.org
2023-06-02  8:28 ` pault at gcc dot gnu.org
2023-08-27  8:51 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99326-4-rzi1a7SXzO@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).