[Bug fortran/99350] New: [9/10/11 Regression] ICE in gfc_get_symbol_decl, at fortran/trans-decl.c:1869

[Bug fortran/99350] New: [9/10/11 Regression] ICE in gfc_get_symbol_decl, at fortran/trans-decl.c:1869

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99350

            Bug ID: 99350
           Summary: [9/10/11 Regression] ICE in gfc_get_symbol_decl, at
                    fortran/trans-decl.c:1869
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Changed between 20200510 and 20200517 :


$ cat z1.f90
program p
   type t
      character(:), pointer :: a
   end type
   type(t) :: z
   character((1.)/0), target :: c = 'abc'
   z%a => c
   associate (y => z%a)
      print *, y
   end associate
end


$ cat z2.f90
program p
   type t
      character(:), pointer :: a
   end type
   type(t) :: z
   character((0.)/0), target :: c = 'abc'
   z%a => c
   associate (y => z%a)
      print *, y
   end associate
end


$ gfortran-11-20200510 -c z1.f90
z1.f90:6:19:

    6 |    character((1.)/0), target :: c = 'abc'
      |                   1
Error: Division by zero at (1)


$ gfortran-11-20210228 -c z1.f90
z1.f90:1:9:

    1 | program p
      |         1
internal compiler error: in gfc_get_symbol_decl, at fortran/trans-decl.c:1869
0x7596ec gfc_get_symbol_decl(gfc_symbol*)
        ../../gcc/fortran/trans-decl.c:1869
0x75c05f generate_local_decl
        ../../gcc/fortran/trans-decl.c:5950
0x71af42 do_traverse_symtree
        ../../gcc/fortran/symbol.c:4170
0x75d004 generate_local_vars
        ../../gcc/fortran/trans-decl.c:6156
0x75d004 gfc_generate_function_code(gfc_namespace*)
        ../../gcc/fortran/trans-decl.c:6815
0x6e3a46 translate_all_program_units
        ../../gcc/fortran/parse.c:6351
0x6e3a46 gfc_parse_file()
        ../../gcc/fortran/parse.c:6620
0x72fd7f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:212

[Bug fortran/99350] [9/10/11 Regression] ICE in gfc_get_symbol_decl, at fortran/trans-decl.c:1869

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99350

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
                 CC|                            |markeggleston at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org
   Last reconfirmed|                            |2021-03-03

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r11-358-gf9f98e59a7f6663f.

[Bug fortran/99350] [9/10/11 Regression] ICE in gfc_get_symbol_decl, at fortran/trans-decl.c:1869

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99350

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |9.4

[Bug fortran/99350] [9/10/11/12 Regression] ICE in gfc_get_symbol_decl, at fortran/trans-decl.c:1869

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99350

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

[Bug fortran/99350] [10/11/12/13 Regression] ICE in gfc_get_symbol_decl, at fortran/trans-decl.c:1869

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99350

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.5                         |10.4

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9 branch is being closed

[Bug fortran/99350] [10/11/12/13 Regression] ICE in gfc_get_symbol_decl, at fortran/trans-decl.c:1869

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99350

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug fortran/99350] [10/11/12/13/14 Regression] ICE in gfc_get_symbol_decl, at fortran/trans-decl.c:1869

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99350

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|87477                       |
                 CC|                            |pault at gcc dot gnu.org

--- Comment #5 from Paul Thomas <pault at gcc dot gnu.org> ---
program p
   character((0.)/0), target :: c = 'abc'
   print *, c
end

Is a sufficient reproducer and so this is not an associate bug.

I am removing it from the blocks PR87477 list but will keep at it. For whatever
reason, the parentheses block the identification of the divide by zero.

Removing the decl.cc chunk in the patch identified in comment #1 (thanks again
Martin!) fixes this problem but changes the error messages in the testcases.

Paul


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87477
[Bug 87477] [meta-bug] [F03] issues concerning the ASSOCIATE statement

[Bug fortran/99350] [10/11/12/13/14 Regression] ICE in gfc_get_symbol_decl, at fortran/trans-decl.c:1869

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99350

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Paul Thomas <pault@gcc.gnu.org>:

https://gcc.gnu.org/g:d08f2e4f74583e27002368989bba197f8eb7f6d2

commit r14-1629-gd08f2e4f74583e27002368989bba197f8eb7f6d2
Author: Paul Thomas <pault@gcc.gnu.org>
Date:   Thu Jun 8 07:11:32 2023 +0100

    Fortran: Fix some more blockers in associate meta-bug [PR87477]

    2023-06-08  Paul Thomas  <pault@gcc.gnu.org>

    gcc/fortran
            PR fortran/87477
            PR fortran/99350
            PR fortran/107821
            PR fortran/109451
            * decl.cc (char_len_param_value): Simplify a copy of the expr
            and replace the original if there is no error.
            * gfortran.h : Remove the redundant field 'rankguessed' from
            'gfc_association_list'.
            * resolve.cc (resolve_assoc_var): Remove refs to 'rankguessed'.
            (resolve_variable): Associate names with constant or structure
            constructor targets cannot have array refs.
            * trans-array.cc (gfc_conv_expr_descriptor): Guard expression
            character length backend decl before using it. Suppress the
            assignment if lhs equals rhs.
            * trans-io.cc (gfc_trans_transfer): Scalarize transfer of
            associate variables pointing to a variable. Add comment.
            * trans-stmt.cc (trans_associate_var): Remove requirement that
            the character length be deferred before assigning the value
            returned by gfc_conv_expr_descriptor. Also, guard the backend
            decl before testing with VAR_P.

    gcc/testsuite/
            PR fortran/99350
            * gfortran.dg/pr99350.f90 : New test.

            PR fortran/107821
            * gfortran.dg/associate_5.f03 : Changed error message.
            * gfortran.dg/pr107821.f90 : New test.

            PR fortran/109451
            * gfortran.dg/associate_61.f90 : New test

[Bug fortran/99350] [10/11/12/13/14 Regression] ICE in gfc_get_symbol_decl, at fortran/trans-decl.c:1869

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99350

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Paul Thomas <pault at gcc dot gnu.org> ---
Fixed on trunk.

Thanks for the report

Paul