From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id A9A8C3858025; Fri,  5 Mar 2021 14:55:07 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A9A8C3858025
From: "unlvsur at live dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/99405] Rotate with mask not optimized on x86 for
 QI/HImode rotates
Date: Fri, 05 Mar 2021 14:55:07 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: missed-optimization
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: unlvsur at live dot com
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-99405-4-SSGJYhSoRt@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99405-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99405-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Mar 2021 14:55:07 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99405

--- Comment #4 from cqwrteur <unlvsur at live dot com> ---
(In reply to Jakub Jelinek from comment #3)
> Created attachment 50307 [details]
> gcc11-pr99405.patch
>=20
> No particular reason, it just feeled weird to have constraints on pre-rel=
oad
> splitters.
>=20
> Anyway, I've tried also to replace the pre-reload splitters with combine
> splitters, but for some reason it didn't work.

I am a noob of the compiler. A question here. Are these pattern matchings as
good as intrinsics? Particularly things like emulated addcarry are extremely
likely to fail.

Should I still prefer intrinsics rol/ror if I can compare to pattern matchi=
ng
versions of std::rotl/std::rotr after this patch?=