From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id F1C6D386EC70; Fri, 5 Mar 2021 15:06:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F1C6D386EC70 From: "unlvsur at live dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/99405] Rotate with mask not optimized on x86 for QI/HImode rotates Date: Fri, 05 Mar 2021 15:06:52 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 11.0 X-Bugzilla-Keywords: missed-optimization X-Bugzilla-Severity: enhancement X-Bugzilla-Who: unlvsur at live dot com X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 15:06:53 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99405 --- Comment #6 from cqwrteur --- (In reply to Jakub Jelinek from comment #5) > The valid C code if it is correct without UB and is pattern matched is > definitely better than some intrinsics, it is portable and can be optimiz= ed > generally sooner and better than the intrinsics. > Just be warned that there are many ways how to write not very good rotate= s, > e.g. (x << y) | (x >> (32 - y)) which has UB for y <=3D 0 or >=3D 32 etc. what about addcarry?=