public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/99509] [OpenMP] 'omp declare target' for global variable → "hasn't been marked to be included in the offloaded code" Date: Mon, 15 Mar 2021 09:13:20 +0000 [thread overview] Message-ID: <bug-99509-4-xVd0Vk3ZaY@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99509-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99509 --- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>: https://gcc.gnu.org/g:f20fe2cb213dffba47ec1b62c625590b5bbe50d7 commit r11-7665-gf20fe2cb213dffba47ec1b62c625590b5bbe50d7 Author: Tobias Burnus <tobias@codesourcery.com> Date: Mon Mar 15 10:12:58 2021 +0100 OpenMP: Fix 'omp declare target' handling for vars [PR99509] For variables with 'declare target' attribute, varpool_node::get_create marks variables as offload; however, if the node already exists, it is not updated. C/C++ may tag decl with 'declare target implicit', which may only be after varpool creation turned into 'declare target' or 'declare target link'; in this case, the tagging has to happen in the FE. gcc/c/ChangeLog: PR c++/99509 * c-decl.c (finish_decl): For 'omp declare target implicit' vars, ensure that the varpool node is marked as offloadable. gcc/cp/ChangeLog: PR c++/99509 * decl.c (cp_finish_decl): For 'omp declare target implicit' vars, ensure that the varpool node is marked as offloadable. libgomp/ChangeLog: PR c++/99509 * testsuite/libgomp.c-c++-common/declare_target-1.c: New test.
next prev parent reply other threads:[~2021-03-15 9:13 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-10 8:45 [Bug c++/99509] New: " burnus at gcc dot gnu.org 2021-03-10 10:15 ` [Bug c++/99509] " burnus at gcc dot gnu.org 2021-03-10 11:37 ` jakub at gcc dot gnu.org 2021-03-10 15:08 ` burnus at gcc dot gnu.org 2021-03-15 9:13 ` cvs-commit at gcc dot gnu.org [this message] 2021-03-15 10:31 ` burnus at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99509-4-xVd0Vk3ZaY@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).