public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/99544] [11 Regression] ICE in expand_mult, at expmed.c:3582
Date: Sat, 13 Mar 2021 08:00:46 +0000	[thread overview]
Message-ID: <bug-99544-4-eY1n7kGVZ6@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99544-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99544

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:bbdf59fdbc2ce41ccfac807b15cf3fac7b465a56

commit r11-7656-gbbdf59fdbc2ce41ccfac807b15cf3fac7b465a56
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Mar 13 08:56:15 2021 +0100

    match.pd: Don't optimize vector X + (X << C) -> X * (1 + (1 << C)) if there
is no mult support [PR99544]

    E.g. on aarch64, the target has V2DImode addition and shift by scalar
    optabs, but doesn't have V2DImode multiply.  The following testcase
    ICEs because this simplification is done after last lowering, but
    generally, even if it is done before that, turning it into a multiplication
    will not be an improvement because that means scalarization, while the
former
    can be done in vectors.

    It would be nice if we added expansion support for vector multiplication
    by uniform constants using shifts and additions like we have for scalar
    multiplication, but that is something that can be done in stage1.

    2021-03-13  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/99544
            * match.pd (X + (X << C) -> X * (1 + (1 << C))): Don't simplify
            if for vector types multiplication can't be done in type's mode.

            * gcc.dg/gomp/pr99544.c: New test.

  parent reply	other threads:[~2021-03-13  8:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11  7:43 [Bug target/99544] New: " asolokha at gmx dot com
2021-03-11  8:45 ` [Bug target/99544] " rguenth at gcc dot gnu.org
2021-03-11 12:24 ` eochoa at gcc dot gnu.org
2021-03-12 10:34 ` jakub at gcc dot gnu.org
2021-03-12 10:48 ` [Bug tree-optimization/99544] " jakub at gcc dot gnu.org
2021-03-12 11:00 ` rguenth at gcc dot gnu.org
2021-03-12 11:00 ` jakub at gcc dot gnu.org
2021-03-12 11:38 ` rguenther at suse dot de
2021-03-13  8:00 ` cvs-commit at gcc dot gnu.org [this message]
2021-03-13  8:55 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99544-4-eY1n7kGVZ6@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).