public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "kabel at blackhole dot sk" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/99559] New: LTO with -Os -ffreestanding -nodefaultlibs may generate call to memcpy, but fail linking even though memcpy is defined
Date: Fri, 12 Mar 2021 10:06:29 +0000	[thread overview]
Message-ID: <bug-99559-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99559

            Bug ID: 99559
           Summary: LTO with -Os -ffreestanding -nodefaultlibs may
                    generate call to memcpy, but fail linking even though
                    memcpy is defined
           Product: gcc
           Version: 10.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
          Assignee: unassigned at gcc dot gnu.org
          Reporter: kabel at blackhole dot sk
                CC: marxin at gcc dot gnu.org
  Target Milestone: ---

Created attachment 50372
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50372&action=edit
test.c

When compiling for target where the assignment operator

  *dst = *src;

will generate a call to memcpy (for example aarch64), and when also using
compile flags

  -ffreestanding -Os -flto

and link flags

  -nodefaultlibs -nostartfiles

the linking will fail with

  undefined reference to `memcpy'

even if memcpy is defined in the source.

The memcpy is optimized away, even though it is used by the = operator. It
needs to be declared with __attribute__((used)) to not be optimized away.

What is interesting is that if the memcpy function is used explicitly, the
compilation may still fail with -Os, because the code will be inlined.

If memcpy is used explicitly multiple times, it may be generated with symbol
name
  memcpy.constprop.0.isra.0
or
  memcpy.isra.0
depending on whether the arguments passed are the same or different.

But the linking fill still fail, because the assignment operator will generate
a call to memcpy, and this symbol is not defined, only memcpy.isra.0 or
memcpy.constprop.0.isra.0 is.

I discovered this recently while trying to make U-Boot compile with LTO. We
have solved it by declaring "memcmp", "memset", "memcpy" and "memmove" with
attribute used, since according to GCC man page, calls to this functions may
still be done when -nodefaultlibs is used.

             reply	other threads:[~2021-03-12 10:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12 10:06 kabel at blackhole dot sk [this message]
2021-03-12 13:20 ` [Bug lto/99559] " rguenth at gcc dot gnu.org
2021-03-12 18:15 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99559-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).