public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/99565] [11 Regression] Bogus identical branches warning when returning references to union members Date: Tue, 16 Mar 2021 13:55:27 +0000 [thread overview] Message-ID: <bug-99565-4-b55N1nt5L6@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99565-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99565 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jakub at gcc dot gnu.org --- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Created attachment 50398 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50398&action=edit gcc11-pr99565.patch If we don't want to warn in this case (I guess pedantically in both C and C++ it matters which exact union member is used even when it has the same type, because only one of them can be active, but practically the compiler will treat them the same anyway and so they are effectively the same), perhaps we could revert Honza's change for OEP_LEXICOGRAPHIC and use that mode for the COND_EXPR warnings (where previously it was used just for then/else variant). But, apparently then we warn for some reason twice on: int a; void foo (bool x) { x ? ++a : ++a; } instead of once. Or add some new OEP_ flag that would be used for -Wduplicated-branches?
next prev parent reply other threads:[~2021-03-16 13:55 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-12 20:08 [Bug c++/99565] New: " johelegp at gmail dot com 2021-03-15 8:31 ` [Bug c++/99565] " rguenth at gcc dot gnu.org 2021-03-15 16:49 ` johelegp at gmail dot com 2021-03-15 16:55 ` [Bug c++/99565] [11 Regression] " mpolacek at gcc dot gnu.org 2021-03-16 13:55 ` jakub at gcc dot gnu.org [this message] 2021-03-16 14:18 ` mpolacek at gcc dot gnu.org 2021-03-16 15:42 ` jakub at gcc dot gnu.org 2021-03-25 12:42 ` cvs-commit at gcc dot gnu.org 2021-03-25 15:59 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99565-4-b55N1nt5L6@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).