public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "johelegp at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/99565] Bogus identical branches warning when returning references to union members
Date: Mon, 15 Mar 2021 16:49:16 +0000	[thread overview]
Message-ID: <bug-99565-4-pSvNmSJsS1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99565-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99565

--- Comment #2 from Johel Ernesto Guerrero Peña <johelegp at gmail dot com> ---
```
<source>: In member function 'int& A::x()':
<source>:6:23: warning: this condition has identical branches
[-Wduplicated-branches]
    6 |   int& x() { return 0 ? a : b; }
      |                     ~~^~~~~~~
```

My actual use case looks more like this: https://godbolt.org/z/W5ajeM.
```C++
struct A {
  char x;
  long long y;
};
struct B {
  double x;
  long long y;
};
struct C {
  int i;
  union {
    A a;
    B b;
  };
  long long& y() { return i ? a.y : b.y; }
};
```
```
<source>: In member function 'long long int& C::y()':
<source>:15:29: warning: this condition has identical branches
[-Wduplicated-branches]
   15 |   long long& y() { return i ? a.y : b.y; }
      |                           ~~^~~~~~~~~~~
```

  parent reply	other threads:[~2021-03-15 16:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12 20:08 [Bug c++/99565] New: " johelegp at gmail dot com
2021-03-15  8:31 ` [Bug c++/99565] " rguenth at gcc dot gnu.org
2021-03-15 16:49 ` johelegp at gmail dot com [this message]
2021-03-15 16:55 ` [Bug c++/99565] [11 Regression] " mpolacek at gcc dot gnu.org
2021-03-16 13:55 ` jakub at gcc dot gnu.org
2021-03-16 14:18 ` mpolacek at gcc dot gnu.org
2021-03-16 15:42 ` jakub at gcc dot gnu.org
2021-03-25 12:42 ` cvs-commit at gcc dot gnu.org
2021-03-25 15:59 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99565-4-pSvNmSJsS1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).