From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 25AEE3861838; Tue, 30 Mar 2021 22:41:24 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 25AEE3861838
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/99588] variable set but not used warning on static _Atomic
 assignment
Date: Tue, 30 Mar 2021 22:41:23 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-99588-4-IzGNYc17Av@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99588-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99588-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Mar 2021 22:41:24 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99588

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:b1fc1f1c4b2e9005c40ed476b067577da2d2ce84

commit r10-9619-gb1fc1f1c4b2e9005c40ed476b067577da2d2ce84
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Mar 19 22:54:31 2021 +0100

    c: Fix up -Wunused-but-set-* warnings for _Atomics [PR99588]

    As the following testcases show, compared to -D_Atomic=3D case we have =
many
    -Wunused-but-set-* warning false positives.
    When an _Atomic variable/parameter is read, we call mark_exp_read on it=
 in
    convert_lvalue_to_rvalue, but build_atomic_assign does not.
    For consistency with the non-_Atomic case where we mark_exp_read the lhs
    for lhs op=3D ... but not for lhs =3D ..., this patch does that too.
    But furthermore we need to pattern match the trees emitted by _Atomic
store,
    so that _Atomic store itself is not marked as being a variable read, but
    when the result of the store is used, we mark it.

    2021-03-19  Jakub Jelinek  <jakub@redhat.com>

            PR c/99588
            * c-typeck.c (mark_exp_read): Recognize what build_atomic_assign
            with modifycode NOP_EXPR produces and mark the _Atomic var as r=
ead
            if found.
            (build_atomic_assign): For modifycode of NOP_EXPR, use
COMPOUND_EXPRs
            rather than STATEMENT_LIST.  Otherwise call mark_exp_read on lh=
s.
            Set TREE_SIDE_EFFECTS on the TARGET_EXPR.

            * gcc.dg/Wunused-var-5.c: New test.
            * gcc.dg/Wunused-var-6.c: New test.=