From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 9F938396E871; Mon, 26 Apr 2021 21:11:36 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9F938396E871
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/99647] arm: GCC generates invalid MVE vmov instruction
Date: Mon, 26 Apr 2021 21:11:36 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: assemble-failure, patch
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: acoplan at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-99647-4-vYTfvydZcT@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99647-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99647-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Apr 2021 21:11:36 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99647

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Alex Coplan
<acoplan@gcc.gnu.org>:

https://gcc.gnu.org/g:9266a101ac9707a164bd241c00675a45aae01373

commit r10-9770-g9266a101ac9707a164bd241c00675a45aae01373
Author: Alex Coplan <alex.coplan@arm.com>
Date:   Thu Apr 8 09:36:57 2021 +0100

    arm: Various MVE vec_duplicate fixes [PR99647]

    This patch fixes various issues with vec_duplicate in the MVE patterns.
    Currently there are two patterns named *mve_mov<mode>. The second of
    these is really a vector duplicate rather than a move, so I've renamed
    it accordingly.

    As it stands, there are several issues with this pattern:
    1. The MVE_types iterator has an entry for TImode, but
       vec_duplicate:TI is invalid.
    2. The mode of the operand to vec_duplicate is SImode, but it should
       vary according to the vector mode iterator.
    3. The second alternative of this pattern is bogus: it allows matching
       symbol_refs (the cause of the PR) and const_ints (which means that it
       matches (vec_duplicate (const_int ...)) which is non-canonical: such
       rtxes should be const_vectors instead and handled by the main vector
       move pattern).

    This patch fixes all of these issues, and removes the redundant
    *mve_vec_duplicate<mode> pattern.

    gcc/ChangeLog:

            PR target/99647
            * config/arm/iterators.md (MVE_vecs): New.
            (V_elem): Also handle V2DF.
            * config/arm/mve.md (*mve_mov<mode>): Rename to ...
            (*mve_vdup<mode>): ... this. Remove second alternative since
            vec_duplicate of const_int is not canonical RTL, and we don't
            want to match symbol_refs.
            (*mve_vec_duplicate<mode>): Delete (pattern is redundant).

    gcc/testsuite/ChangeLog:

            PR target/99647
            * gcc.c-torture/compile/pr99647.c: New test.

    (cherry picked from commit 67d56b272021363eb58c319ca3b73beba3a60817)=