public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "StevenSun2021 at hotmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/99686] ICE when using both concepts and full specialization
Date: Wed, 05 May 2021 00:09:01 +0000	[thread overview]
Message-ID: <bug-99686-4-Wa38eZcZWd@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99686-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99686

--- Comment #5 from Steven Sun <StevenSun2021 at hotmail dot com> ---
I learn a little about gcc recently. I think I got a vague idea of what's going
on inside.

In c++17 mode with concepts, and with my code in comment 1.

The compiler decides to instantiate from the concept constrained template.

--------------------------------------------------------------------

Usually the compiler should generate a new function on the AST, but this time
there's already one function (fully specialized) on the AST.

So, the function `start_preparsed_function` in the below link returns at the
quoted line. It's thinking "Ah! There's already a function, no need to allocate
a new one."

https://gcc.gnu.org/git?p=gcc.git;a=blob;f=gcc/cp/decl.c;h=316ad4c1426940bd4f51197a6297eefc24064fec;hb=HEAD#l16696

--------------------------------------------------------------------

Then the flow goes back to the function in the link below. It's thinking "Since
I'm gonna add a new function, new function is allocated on AST. Everything
should be prepared for me!"

More specifially, it will assume the `cfun` in the correct state set by the
`start_preparsed_function`.

But `cfun` is null, since the `start_preparsed_function` returns early. This is
the direct cause of segfault, which triggered at the line below.

https://gcc.gnu.org/git?p=gcc.git;a=blob;f=gcc/cp/pt.c;h=36a8cb5df5d36337c18e1547e775b747f59a087f;hb=HEAD#l25932

--------------------------------------------------------------------

In conclusion, The compiler doesn't consider there would be a situation that an
instatiation is still needed when full specialzation is provided. This break
the invariants.

  parent reply	other threads:[~2021-05-05  0:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-20 19:21 [Bug c++/99686] New: ICE when concepts on C++17 when providing both T&& and const T& specialization StevenSun2021 at hotmail dot com
2021-03-20 19:43 ` [Bug c++/99686] " StevenSun2021 at hotmail dot com
2021-03-21  6:51 ` [Bug c++/99686] ICE when using both concepts and full specialization webrown.cpp at gmail dot com
2021-03-25 11:35 ` StevenSun2021 at hotmail dot com
2021-03-25 12:32 ` webrown.cpp at gmail dot com
2021-05-05  0:09 ` StevenSun2021 at hotmail dot com [this message]
2021-05-05  0:33 ` StevenSun2021 at hotmail dot com
2021-05-07 13:15 ` StevenSun2021 at hotmail dot com
2021-05-07 14:35 ` StevenSun2021 at hotmail dot com
2022-12-07 15:55 ` [Bug c++/99686] ICE when using concepts on function template before c++20 (Reason already found) ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99686-4-Wa38eZcZWd@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).