public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "vincent-gcc at vinc17 dot net" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/99707] missing -Woverflow warning in floating-point to integer conversion for known but non-constant value
Date: Mon, 22 Mar 2021 11:18:51 +0000	[thread overview]
Message-ID: <bug-99707-4-4qpfkS9pof@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99707-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99707

--- Comment #3 from Vincent Lefèvre <vincent-gcc at vinc17 dot net> ---
(In reply to Andrew Pinski from comment #1)
> Gcc does not know that x will be negative.

Actually, the code should have been (without the volatile):

#include <stdio.h>

int main (void)
{
  double x = -1.0;
  unsigned int i = x;

  printf ("%u\n", i);
  if (x == -1.0)
    printf ("%u\n", i);
  return 0;
}

I don't get the warning either, and due to the "double x = -1.0;", GCC knows
that x is negative.

> -Wconversion might warn about this but I have not tried.

The test is done with -Wconversion.

(In reply to Andrew Pinski from comment #2)
> Also this might be caught at runtime with -fsanitizer=undefined but I have
> not tried yet. Since this is undefined behavior in this case unlike the
> original PR93806.

After checking... This is not undefined behavior, but the value is unspecified.
F.4: "[...] if the floating value is infinite or NaN or if the integral part of
the floating value exceeds the range of the integer type, then the “invalid”
floating-point exception is raised and the resulting value is unspecified."

  parent reply	other threads:[~2021-03-22 11:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22  9:50 [Bug c/99707] New: missing -Woverflow " vincent-gcc at vinc17 dot net
2021-03-22 10:02 ` [Bug c/99707] missing -Woverflow warning " pinskia at gcc dot gnu.org
2021-03-22 10:05 ` pinskia at gcc dot gnu.org
2021-03-22 11:18 ` vincent-gcc at vinc17 dot net [this message]
2021-03-22 16:45 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99707-4-4qpfkS9pof@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).