public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/99708] __SIZEOF_FLOAT128__ not defined on powerpc64le-linux Date: Thu, 10 Mar 2022 09:31:05 +0000 [thread overview] Message-ID: <bug-99708-4-SIOT3pLFTH@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99708-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99708 --- Comment #31 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:6f8abf2b9ff4f165a61295cdb3525ce1da2a77c6 commit r12-7576-g6f8abf2b9ff4f165a61295cdb3525ce1da2a77c6 Author: Jakub Jelinek <jakub@redhat.com> Date: Thu Mar 10 10:22:27 2022 +0100 rs6000: Fix up __SIZEOF_{FLOAT,IBM}128__ defines [PR99708] As mentioned in the PR, right now on powerpc* __SIZEOF_{FLOAT,IBM}128__ macros are predefined unconditionally, because {ieee,ibm}128_float_type_node is always non-NULL, doesn't reflect whether __ieee128 or __ibm128 are actually supported or not. Based on patch review discussions, the following patch: 1) allows __ibm128 to be used in the sources even when !TARGET_FLOAT128_TYPE, as long as long double is double double 2) ensures ibm128_float_type_node is non-NULL only if __ibm128 is supported 3) ensures ieee128_float_type_node is non-NULL only if __ieee128 is supported (aka when TARGET_FLOAT128_TYPE) 4) predefines __SIZEOF_IBM128__ only when ibm128_float_type_node != NULL 5) newly predefines __SIZEOF_IEEE128__ if ieee128_float_type_node != NULL 6) predefines __SIZEOF_FLOAT128__ whenever ieee128_float_type_node != NULL and __float128 macro is predefined to __ieee128 7) removes ptr_*128_float_type_node which nothing uses 8) in order not to ICE during builtin initialization when ibm128_float_type_node == NULL, uses long_double_type_node as fallback for the __builtin_{,un}pack_ibm128 builtins 9) errors when those builtins are called used when ibm128_float_type_node == NULL (during their expansion) 10) moves the {,un}packif -> {,un}packtf remapping for these builtins in expansion earlier, so that we don't ICE on them if not -mabi=ieeelongdouble 2022-03-10 Jakub Jelinek <jakub@redhat.com> PR target/99708 * config/rs6000/rs6000.h (enum rs6000_builtin_type_index): Remove RS6000_BTI_ptr_ieee128_float and RS6000_BTI_ptr_ibm128_float. (ptr_ieee128_float_type_node, ptr_ibm128_float_type_node): Remove. * config/rs6000/rs6000-builtin.cc (rs6000_type_string): Return "**NULL**" if type_node is NULL first. Handle ieee128_float_type_node. (rs6000_init_builtins): Don't initialize ptr_ieee128_float_type_node and ptr_ibm128_float_type_node. Set ibm128_float_type_node and ieee128_float_type_node to NULL rather than long_double_type_node if they aren't supported. Do support __ibm128 even if !TARGET_FLOAT128_TYPE when long double is double double. (rs6000_expand_builtin): Error if bif_is_ibm128 and !ibm128_float_type_node. Remap RS6000_BIF_{,UN}PACK_IF to RS6000_BIF_{,UN}PACK_TF much earlier and only use bif_is_ibm128 check for it. * config/rs6000/rs6000-c.cc (rs6000_target_modify_macros): Define __SIZEOF_FLOAT128__ here and only iff __float128 macro is defined. (rs6000_cpu_cpp_builtins): Don't define __SIZEOF_FLOAT128__ here. Define __SIZEOF_IBM128__=16 if ieee128_float_type_node is non-NULL. Formatting fix. * config/rs6000/rs6000-gen-builtins.cc: Document ibm128 attribute. (struct attrinfo): Add isibm128 member. (TYPE_MAP_SIZE): Remove. (type_map): Use [] instead of [TYPE_MAP_SIZE]. For "if" use ibm128_float_type_node only if it is non-NULL, otherwise fall back to long_double_type_node. Remove "pif" entry. (parse_bif_attrs): Handle ibm128 attribute and print it for debugging. (write_decls): Output bif_ibm128_bit and bif_is_ibm128. (write_type_node): Use sizeof type_map / sizeof type_map[0] instead of TYPE_MAP_SIZE. (write_bif_static_init): Handle isibm128. * config/rs6000/rs6000-builtins.def: Document ibm128 attribute. (__builtin_pack_ibm128, __builtin_unpack_ibm128): Add ibm128 attribute. * gcc.dg/pr99708.c: New test. * gcc.target/powerpc/pr99708-2.c: New test. * gcc.target/powerpc/convert-fp-128.c (mode_kf): Define only if __FLOAT128_TYPE__ is defined.
next prev parent reply other threads:[~2022-03-10 9:31 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-22 9:56 [Bug target/99708] New: " jakub at gcc dot gnu.org 2021-03-22 16:42 ` [Bug target/99708] " segher at gcc dot gnu.org 2021-03-22 17:38 ` jakub at gcc dot gnu.org 2021-03-23 20:37 ` segher at gcc dot gnu.org 2021-03-24 10:17 ` jakub at gcc dot gnu.org 2021-03-24 14:50 ` redi at gcc dot gnu.org 2021-03-24 20:57 ` segher at gcc dot gnu.org 2021-03-24 21:13 ` redi at gcc dot gnu.org 2022-03-03 15:34 ` redi at gcc dot gnu.org 2022-03-03 15:37 ` redi at gcc dot gnu.org 2022-03-03 15:39 ` redi at gcc dot gnu.org 2022-03-03 16:30 ` segher at gcc dot gnu.org 2022-03-03 16:35 ` segher at gcc dot gnu.org 2022-03-03 17:05 ` jakub at gcc dot gnu.org 2022-03-03 17:52 ` jakub at gcc dot gnu.org 2022-03-03 18:01 ` jakub at gcc dot gnu.org 2022-03-03 18:07 ` jakub at gcc dot gnu.org 2022-03-03 23:03 ` segher at gcc dot gnu.org 2022-03-03 23:05 ` segher at gcc dot gnu.org 2022-03-04 9:28 ` jakub at gcc dot gnu.org 2022-03-04 13:46 ` segher at gcc dot gnu.org 2022-03-04 17:37 ` jakub at gcc dot gnu.org 2022-03-04 18:07 ` segher at gcc dot gnu.org 2022-03-04 18:07 ` segher at gcc dot gnu.org 2022-03-04 18:10 ` jakub at gcc dot gnu.org 2022-03-04 19:03 ` segher at gcc dot gnu.org 2022-03-04 19:30 ` jakub at gcc dot gnu.org 2022-03-04 20:22 ` segher at gcc dot gnu.org 2022-03-05 16:23 ` cvs-commit at gcc dot gnu.org 2022-03-06 1:16 ` cvs-commit at gcc dot gnu.org 2022-03-07 20:46 ` segher at gcc dot gnu.org 2022-03-10 9:31 ` cvs-commit at gcc dot gnu.org [this message] 2022-03-10 23:02 ` ebotcazou at gcc dot gnu.org 2022-03-10 23:10 ` jakub at gcc dot gnu.org 2022-03-11 23:43 ` cvs-commit at gcc dot gnu.org 2022-03-12 0:09 ` cvs-commit at gcc dot gnu.org 2022-05-20 2:36 ` bergner at gcc dot gnu.org 2023-04-15 2:58 ` cvs-commit at gcc dot gnu.org 2023-04-15 8:51 ` redi at gcc dot gnu.org 2023-04-15 8:52 ` redi at gcc dot gnu.org 2024-04-10 15:48 ` meissner at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99708-4-SIOT3pLFTH@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).