public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/99728] code pessimization when using wrapper classes around SIMD types Date: Fri, 02 Jul 2021 09:52:43 +0000 [thread overview] Message-ID: <bug-99728-4-K2baQ3kC33@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99728-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99728 --- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> --- Created attachment 51100 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51100&action=edit hack The attached tries to rewrite the aggregate assignments into a load/store sequence producing _33 = VIEW_CONVERT_EXPR<vector(32) unsigned char>(d_42(D)->lam2D.32702); VIEW_CONVERT_EXPR<vector(32) unsigned char>(d_42(D)->lam1D.32701) = _33; from originally d_42(D)->lam1D.32701 = d_42(D)->lam2D.32702; that's a bit ugly but still falls short of doing the full store-motion but at least now moves all but the above store: ... _35 = _36 + val$v_63; _30 = VIEW_CONVERT_EXPR<vector(32) unsigned char>(_56); VIEW_CONVERT_EXPR<vector(32) unsigned char>(*d_28(D).lam1D.32701) = _30; *d_28(D).lam2D.32702.vD.32579 = _35; il_33 = il_69 + 1; l_34 = l_68 + 2; if (lmax_26(D) >= l_34) goto <bb 6>; [89.00%] else goto <bb 7>; [11.00%] <bb 6> [local count: 850510901]: goto <bb 3>; [100.00%] <bb 7> [local count: 105119324]: # _84 = PHI <_30(3)> # _85 = PHI <_35(3)> # d__v_lsm.37_86 = PHI <d__v_lsm.37_74(3)> # d__v_lsm.38_87 = PHI <d__v_lsm.38_75(3)> # d__v_lsm.39_88 = PHI <d__v_lsm.39_76(3)> # d__v_lsm.40_89 = PHI <d__v_lsm.40_77(3)> MEM[(struct TvsimpleD.32577 *)d_28(D) + 192B].vD.32579 = d__v_lsm.37_86; MEM[(struct TvsimpleD.32577 *)d_28(D) + 224B].vD.32579 = d__v_lsm.38_87; MEM[(struct TvsimpleD.32577 *)d_28(D) + 256B].vD.32579 = d__v_lsm.39_88; MEM[(struct TvsimpleD.32577 *)d_28(D) + 288B].vD.32579 = d__v_lsm.40_89; VIEW_CONVERT_EXPR<vector(32) unsigned char>(*d_28(D).lam1D.32701) = _84; *d_28(D).lam2D.32702.vD.32579 = _85; the dependence analysis of store-motion considers the last stores (ref 14 and 15) dependent: Querying dependency of refs 2 and 15: dependent. Querying RAW dependencies of ref 2 in loop 1: dependent Querying dependency of refs 13 and 14: dependent. Querying RAW dependencies of ref 13 in loop 1: dependent Querying dependency of refs 14 and 13: dependent. Querying SM WAR dependencies of ref 14 in loop 1: dependent Querying dependency of refs 15 and 2: dependent. Querying SM WAR dependencies of ref 15 in loop 1: dependent That's the usual issue of LIM needing to identify "identical" refs but appearanlty failing to do so for: Memory reference 2: MEM[(const struct Tvsimple *)d_28(D) + 128B].v Memory reference 15: *d_28(D).lam2.v which is because we don't factor the MEM_REF contained offset. I'll see to do that independently of the "hack" (which I'm not sure is an appropriate way of avoiding to change LIM to deal with aggregates ...)
next prev parent reply other threads:[~2021-07-02 9:52 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-23 13:22 [Bug c++/99728] New: " martin@mpa-garching.mpg.de 2021-03-23 13:23 ` [Bug c++/99728] " martin@mpa-garching.mpg.de 2021-03-23 13:50 ` martin@mpa-garching.mpg.de 2021-03-23 13:56 ` amonakov at gcc dot gnu.org 2021-03-23 14:08 ` kretz at kde dot org 2021-03-23 14:28 ` martin@mpa-garching.mpg.de 2021-03-23 14:32 ` kretz at kde dot org 2021-03-23 14:36 ` martin@mpa-garching.mpg.de 2021-03-23 15:00 ` redi at gcc dot gnu.org 2021-03-24 8:52 ` [Bug tree-optimization/99728] " rguenth at gcc dot gnu.org 2021-03-24 9:15 ` kretz at kde dot org 2021-03-24 9:26 ` rguenther at suse dot de 2021-07-02 8:27 ` martin@mpa-garching.mpg.de 2021-07-02 9:52 ` rguenth at gcc dot gnu.org [this message] 2021-07-02 9:52 ` rguenth at gcc dot gnu.org 2021-07-02 10:53 ` rguenth at gcc dot gnu.org 2021-07-02 11:55 ` rguenth at gcc dot gnu.org 2021-07-07 11:49 ` cvs-commit at gcc dot gnu.org 2021-07-07 12:09 ` rguenth at gcc dot gnu.org 2021-07-07 13:59 ` rguenth at gcc dot gnu.org 2021-07-14 11:37 ` rguenth at gcc dot gnu.org 2021-07-14 13:04 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99728-4-K2baQ3kC33@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).