From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 20502386102C; Tue, 23 Mar 2021 19:54:11 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20502386102C
From: "iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/99733] darwin: missing ':' in error message about munmap
Date: Tue, 23 Mar 2021 19:54:10 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: trivial
X-Bugzilla-Who: iains at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_status resolution
Message-ID: <bug-99733-4-9whUVZCHCl@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99733-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99733-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Mar 2021 19:54:11 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99733

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Roland Illig from comment #0)
> config/host-darwin.c says:
> > could not unmap %<pch_address_space%> %m
>=20
> There is a ':' missing before the '%m'.

(I changed this to avoid a diagnostic about "unquoted identifier or keyword=
".)

Personally, I would have preferred "'pch_address_space' : " but that trigge=
rs
another warning about punctuation in diagnostics. So I left the colon out (=
on
purpose, it was not an accident ;) ).

However, I have not a strong feeling about it - and if it helps translation=
 to
leave it in all OK with me.

So we have now got "'pch_address_space': "

> Plus, there is a unit test missing to demonstrate this typo.
> Granted, this error message may be hard to produce anyway.

Yeah, I don't know a reasonable way to do that.

As noted in the commit message for the change I am not sure that the messag=
e is
really a worthwhile end-user one, since there's nothing that they can do ab=
out
it - however, fixing that is not something for stage 4.=