public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "roland.illig at gmx dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/99733] darwin: missing ':' in error message about munmap
Date: Tue, 23 Mar 2021 22:50:16 +0000	[thread overview]
Message-ID: <bug-99733-4-qgOQzzStrJ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99733-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99733

--- Comment #3 from Roland Illig <roland.illig at gmx dot de> ---
(In reply to Iain Sandoe from comment #2)
> Personally, I would have preferred "'pch_address_space' : " but that
> triggers another warning about punctuation in diagnostics. So I left the
> colon out (on purpose, it was not an accident ;) ).

It should have been as simple as writing %<pch_address_space%> instead of
'pch_address_space'.  Wasn't the diagnostic clear enough?  Martin Sebor did put
a lot of work into making the diagnostics uniform in style in 2019.

>From c-format.c:
> inform (format_string_loc,
>     "if avoiding the apostrophe is not feasible, enclose "
>     "it in a pair of %qs and %qs directives instead",
>     "%<", "%>");

      parent reply	other threads:[~2021-03-23 22:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 16:44 [Bug target/99733] New: " roland.illig at gmx dot de
2021-03-23 17:11 ` [Bug target/99733] " redi at gcc dot gnu.org
2021-03-23 18:52 ` egallager at gcc dot gnu.org
2021-03-23 19:46 ` cvs-commit at gcc dot gnu.org
2021-03-23 19:54 ` iains at gcc dot gnu.org
2021-03-23 22:50 ` roland.illig at gmx dot de [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99733-4-qgOQzzStrJ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).