public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/99746] [11 Regression] ICE in vect_get_vec_defs_for_operand, at tree-vect-stmts.c:1450 Date: Wed, 24 Mar 2021 10:42:47 +0000 [thread overview] Message-ID: <bug-99746-4-d74JgTRTfi@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99746-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99746 --- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> --- Btw, the following also works as a fix but obviously I'm not in a position to fully evaluate this. That said, hybrid SLP detection was rewritten during SLP pattern development so the requirement to hook things up as regular pattern might no longer be there. Tamar - can you fully test this on aarch64? I see the testcase from this PR being hybrid vectorized appropriately then. diff --git a/gcc/tree-vect-slp-patterns.c b/gcc/tree-vect-slp-patterns.c index 85f2d03754d..cdd61e9a5cf 100644 --- a/gcc/tree-vect-slp-patterns.c +++ b/gcc/tree-vect-slp-patterns.c @@ -571,14 +571,8 @@ complex_pattern::build (vec_info *vinfo) STMT_VINFO_RELEVANT (call_stmt_info) = vect_used_in_scope; STMT_SLP_TYPE (call_stmt_info) = pure_slp; - /* add_pattern_stmt can't be done in vect_mark_pattern_stmts because - the non-SLP pattern matchers already have added the statement to VINFO - by the time it is called. Some of them need to modify the returned - stmt_info. vect_mark_pattern_stmts is called by recog_pattern and it - would increase the size of each pattern with boilerplate code to make - the call there. */ - vect_mark_pattern_stmts (vinfo, stmt_info, call_stmt, - SLP_TREE_VECTYPE (node)); + gimple_set_bb (call_stmt, gimple_bb (stmt_info->stmt)); + STMT_VINFO_VECTYPE (call_stmt_info) = SLP_TREE_VECTYPE (node); STMT_VINFO_SLP_VECT_ONLY_PATTERN (call_stmt_info) = true; /* Since we are replacing all the statements in the group with the same
next prev parent reply other threads:[~2021-03-24 10:42 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-24 6:33 [Bug tree-optimization/99746] New: " asolokha at gmx dot com 2021-03-24 8:34 ` [Bug tree-optimization/99746] " tnfchris at gcc dot gnu.org 2021-03-24 8:38 ` marxin at gcc dot gnu.org 2021-03-24 8:40 ` marxin at gcc dot gnu.org 2021-03-24 8:51 ` tnfchris at gcc dot gnu.org 2021-03-24 9:02 ` marxin at gcc dot gnu.org 2021-03-24 9:05 ` marxin at gcc dot gnu.org 2021-03-24 9:20 ` [Bug tree-optimization/99746] [11 Regression] " rguenth at gcc dot gnu.org 2021-03-24 9:22 ` tnfchris at gcc dot gnu.org 2021-03-24 9:51 ` rguenth at gcc dot gnu.org 2021-03-24 10:03 ` tnfchris at gcc dot gnu.org 2021-03-24 10:15 ` asolokha at gmx dot com 2021-03-24 10:17 ` rguenth at gcc dot gnu.org 2021-03-24 10:42 ` rguenth at gcc dot gnu.org [this message] 2021-03-24 16:49 ` tnfchris at gcc dot gnu.org 2021-03-24 16:50 ` tnfchris at gcc dot gnu.org 2021-03-25 3:56 ` asolokha at gmx dot com 2021-03-25 9:04 ` cvs-commit at gcc dot gnu.org 2021-03-25 9:05 ` rguenth at gcc dot gnu.org 2021-03-26 7:22 ` tnfchris at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99746-4-d74JgTRTfi@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).