public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/99748] MVE: Wrong code at -O0 with float to integer conversion Date: Fri, 23 Apr 2021 11:40:20 +0000 [thread overview] Message-ID: <bug-99748-4-QXOIFTAlqZ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99748-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99748 --- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-10 branch has been updated by Alex Coplan <acoplan@gcc.gnu.org>: https://gcc.gnu.org/g:283367662c25057fd7c9c98257cca858f85b75fc commit r10-9755-g283367662c25057fd7c9c98257cca858f85b75fc Author: Alex Coplan <alex.coplan@arm.com> Date: Tue Apr 6 09:06:27 2021 +0100 arm: Fix PCS for SFmode -> SImode libcalls [PR99748] This patch fixes PR99748 which shows us trying to pass the argument to __aeabi_f2iz in the VFP register s0 when the library function is expecting to use the GPR r0. It also fixes the __aeabi_f2uiz case which was broken in the same way. For the testcase in the PR, here is the code we generate before the patch (with -mfloat-abi=hard -march=armv8.1-m.main+mve -O0): main: push {r7, lr} sub sp, sp, #8 add r7, sp, #0 mov r3, #1065353216 str r3, [r7, #4] @ float vldr.32 s0, [r7, #4] bl __aeabi_f2iz mov r3, r0 cmp r3, #1 [...] This becomes: main: push {r7, lr} sub sp, sp, #8 add r7, sp, #0 mov r3, #1065353216 str r3, [r7, #4] @ float ldr r0, [r7, #4] @ float bl __aeabi_f2iz mov r3, r0 cmp r3, #1 [...] after the patch. We see a similar change for the same testcase with a cast to unsigned instead of int. gcc/ChangeLog: PR target/99748 * config/arm/arm.c (arm_libcall_uses_aapcs_base): Also use base PCS for [su]fix_optab. (cherry picked from commit 16ea7f57891d3fe885ee55b2917208695e184714)
next prev parent reply other threads:[~2021-04-23 11:40 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-24 10:04 [Bug target/99748] New: " acoplan at gcc dot gnu.org 2021-03-24 10:06 ` [Bug target/99748] " acoplan at gcc dot gnu.org 2021-03-24 10:15 ` acoplan at gcc dot gnu.org 2021-03-31 14:35 ` acoplan at gcc dot gnu.org 2021-04-06 8:07 ` cvs-commit at gcc dot gnu.org 2021-04-06 8:14 ` acoplan at gcc dot gnu.org 2021-04-23 11:40 ` cvs-commit at gcc dot gnu.org [this message] 2021-04-23 11:41 ` acoplan at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99748-4-QXOIFTAlqZ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).