From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 4564C3858436; Mon,  7 Mar 2022 19:21:30 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4564C3858436
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/99771] Analyzer diagnostics should not say "<unknown>"
Date: Mon, 07 Mar 2022 19:21:29 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: analyzer
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: dmalcolm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-99771-4-xSnDouYkru@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99771-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99771-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2022 19:21:30 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99771

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:0af37ad4422052be4b7f779737e14c80e57d0ad9

commit r12-7525-g0af37ad4422052be4b7f779737e14c80e57d0ad9
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Mon Mar 7 14:19:30 2022 -0500

    analyzer: fix leak suppression at end of 'main' [PR101983]

    PR analyzer/101983 reports what I thought were false positives
    from -Wanalyzer-malloc-leak, but on closer inspection, the
    analyzer is correctly reporting heap-allocated buffers that are
    no longer reachable.

    However, these "leaks" occur at the end of "main".  The analyzer already
    has some logic to avoid reporting leaks at the end of main, where the
    leak is detected at the end of the EXIT basic block.  However, in this
case,
    the leak is detected at the clobber in BB 2 here:
      <bb 2> :
      func (&res);
      res =3D{v} {CLOBBER(eol)};
      _4 =3D 0;

      <bb 3> :
    <L0>:
      return _4;

    where we have a chain BB 2 -> BB 3 -> EXIT BB.

    This patch generalizes the "are we at the end of 'main'" detection to
    handle such cases, silencing -Wanalyzer-malloc-leak on them.

    There's a remaining issue where the analyzer unhelpfully describes one
    of the leaking values as '<unknown>', rather than 'res.a', but I'm
    leaving that for a followup (covered by PR analyzer/99771).

    gcc/analyzer/ChangeLog:
            PR analyzer/101983
            * engine.cc (returning_from_function_p): New.
            (impl_region_model_context::on_state_leak): Use it when rejecti=
ng
            leaks at the return from "main".

    gcc/testsuite/ChangeLog:
            PR analyzer/101983
            * gcc.dg/analyzer/pr101983-main.c: New test.
            * gcc.dg/analyzer/pr101983-not-main.c: New test.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>=