From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 4FF7E3858D1E; Mon, 20 May 2024 20:44:39 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4FF7E3858D1E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1716237880;
	bh=ws0Rq9jhT6vQXcGGOIr9rxpKl0/dTsXiLQEzMd38hHY=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=ywCo7k45qe6/qbnqKmZICfAfGfxGsiMjnSukPk5OLas9Y8WC12pADwketgYGYdQJ5
	 8SIIHbXRqhobGmoHQG9Cjnn3pAB4+l2DOa6TLVfY848YkCudUab/sNLh0lfW+FZCSJ
	 K1bsRkGQoc9k7W5v+Ssw6iAv1hgaKvgLdYx5kOGk=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/99798] ICE when compiling a variant of pr87907
Date: Mon, 20 May 2024 20:44:37 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: ice-on-invalid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P4
X-Bugzilla-Assigned-To: mikael at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-99798-4-LzaKZjk7rB@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99798-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99798-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99798

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Mikael Morin <mikael@gcc.gnu.org>:

https://gcc.gnu.org/g:38d1761c0c94b77a081ccc180d6e039f7a670468

commit r15-698-g38d1761c0c94b77a081ccc180d6e039f7a670468
Author: Mikael Morin <mikael@gcc.gnu.org>
Date:   Sun May 12 15:16:23 2024 +0200

    fortran: Assume there is no cyclic reference with submodule symbols
[PR99798]

    This prevents a premature release of memory with procedure symbols from
    submodules, causing random compiler crashes.

    The problem is a fragile detection of cyclic references, which can match
    with procedures host-associated from a module in submodules, in cases w=
here
it
    shouldn't.  The formal namespace is released, and with it the dummy
arguments
    symbols of the procedure.  But there is no cyclic reference, so the
procedure
    symbol itself is not released and remains, with pointers to its dummy
arguments
    now dangling.

    The fix adds a condition to avoid the case, and refactors to a new
predicate
    by the way.  Part of the original condition is also removed, for lack o=
f a
    reason to keep it.

            PR fortran/99798

    gcc/fortran/ChangeLog:

            * symbol.cc (gfc_release_symbol): Move the condition guarding
            the handling cyclic references...
            (cyclic_reference_break_needed): ... here as a new predicate.
            Remove superfluous parts.  Add a condition preventing any prema=
ture
            release with submodule symbols.

    gcc/testsuite/ChangeLog:

            * gfortran.dg/submodule_33.f08: New test.=