From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 94B973945C08; Thu,  8 Apr 2021 13:46:10 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 94B973945C08
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/99846] [11 regression] std::variant comparison
 operator error for recursive type
Date: Thu, 08 Apr 2021 13:46:10 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: redi at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 11.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-99846-4-dviMGEdyJc@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99846-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99846-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2021 13:46:10 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99846

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at gcc dot gnu.org

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Preprocessing the attached testcase with GCC 10 (using -std=3Dc++20) and
compiling  with GCC 11 shows the error. Possibly a compiler bug (or invalid
code in the library, which gcc 10 doesn't complain about).

It started to fail on trunk with r11-2774

    c++: Check satisfaction before non-dep convs. [CWG2369]

    It's very hard to use concepts to protect a template from hard errors d=
ue
to
    unwanted instantiation if constraints aren't checked until after doing =
all
    substitution and checking of non-dependent conversions.

    It was pretty straightforward to insert the satisfaction check into the
    logic, but I needed to make the 3-parameter version of
    satisfy_declaration_constraints call push_tinst_level like the 2-parame=
ter
    version already does.  For simplicity, I also made it add any needed ou=
ter
    template arguments from the TEMPLATE_DECL to the args.

    The testsuite changes are mostly because this change causes unsatisfact=
ion
    to cause deduction to fail rather than reject the candidate later in
    overload resolution.

    gcc/cp/ChangeLog:

            DR 2369
            * cp-tree.h (push_tinst_level, push_tinst_level_loc): Declare.
            * constraint.cc (satisfy_declaration_constraints):
            Use add_outermost_template_args and push_tinst_level.
            * pt.c (add_outermost_template_args): Handle getting
            a TEMPLATE_DECL as the first argument.
            (push_tinst_level, push_tinst_level_loc): No longer static.
            (fn_type_unification): Check satisfaction before non-dependent
            conversions.=