public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/99872] [11 Regression] optimizations sometimes lead to missing asm prefixes Date: Wed, 07 Apr 2021 13:52:13 +0000 [thread overview] Message-ID: <bug-99872-4-54IiJHzqyn@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99872-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99872 --- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:b51321bc5193b65b308a26663fc02f786ba6cc89 commit r11-8028-gb51321bc5193b65b308a26663fc02f786ba6cc89 Author: Jakub Jelinek <jakub@redhat.com> Date: Wed Apr 7 15:51:15 2021 +0200 varasm: Fix up constpool alias handling [PR99872] Last year, I have added in r11-2944-g0106300f6c3f7bae5eb1c46dbd45aa07c94e1b15 (aka PR54201 fix) code to find bitwise duplicates in constant pool and output them as aliases instead of duplicating the data. Unfortunately this broke mingw32 -m32. On most targets, ASM_GENERATE_INTERNAL_LABEL with "LC" emits something like *.LC123 and the targets don't add user label prefixes, so the aliases that we print should be something like .set .LC5, .LC6 or .set .LC5, .LC6 + 8 and I wasn't sure if ASM_OUTPUT_DEF can handle the * and therefore I have stripped it. But, on mingw32 -m32, ASM_GENERATE_INTERNAL_LABEL with "LC" emits *LC123 and the target has user label prefixes, which means what I wrote results in LC6: ... .set _LC5, _LC6 which results in unresolved symbols. I went through the ASM_OUTPUT_DEF definitions of all targets and all of them use assemble_name twice under the hood (with various differences on what they print before, in between or after those names). And assemble_name handles the name encoding properly, so if we pass it ASM_OUTPUT_DEF (..., "*.LC123", "*.LC456+16") it will emit .LC123 and .LC456+16 and if we pass it "*LC789", it will emit LC789. 2021-04-07 Jakub Jelinek <jakub@redhat.com> PR target/99872 * varasm.c (output_constant_pool_contents): Don't strip name encoding from XSTR (desc->sym, 0) or from label before passing those to ASM_OUTPUT_DEF.
next prev parent reply other threads:[~2021-04-07 13:52 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-01 17:14 [Bug c/99872] New: " jyong at gcc dot gnu.org 2021-04-06 7:33 ` [Bug c/99872] " rguenth at gcc dot gnu.org 2021-04-06 8:27 ` jyong at gcc dot gnu.org 2021-04-06 11:09 ` jakub at gcc dot gnu.org 2021-04-06 11:34 ` [Bug target/99872] " jakub at gcc dot gnu.org 2021-04-06 16:27 ` jyong at gcc dot gnu.org 2021-04-06 18:10 ` jyong at gcc dot gnu.org 2021-04-07 7:38 ` jakub at gcc dot gnu.org 2021-04-07 13:52 ` cvs-commit at gcc dot gnu.org [this message] 2021-04-07 13:58 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99872-4-54IiJHzqyn@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).