public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/99873] [11 Regression] GCC no longer makes as much use of ST3
Date: Wed, 07 Apr 2021 14:22:07 +0000	[thread overview]
Message-ID: <bug-99873-4-EOnCoogqvi@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99873-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99873

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.org>:

https://gcc.gnu.org/g:5c5b31975e62b4c52d76dc5efd9dc717a361c710

commit r11-8029-g5c5b31975e62b4c52d76dc5efd9dc717a361c710
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Wed Apr 7 15:21:55 2021 +0100

    vect: Don't split store groups if we have IFN_STORE_LANES [PR99873]

    As noted in the PR, we were no longer using ST3 for the testcase and
    instead stored each lane individually.  This is because we'd split
    the store group during SLP and couldn't recover when SLP failed.

    However, we can also get better code with ST3 and ST4 even if SLP would
    have succeeded, such as for vect-complex-5.c.  I'm not sure exactly
    where the cut-off point is, but it seems reasonable to allow the split
    if either of the new groups would operate on full vectors *within*
    rather than across scalar loop iterations.

    E.g. on a Cortex-A57, pr99873_3.c performs better using ST4 while
    pr99873_2.c performs better with SLP.

    Another factor is that SLP can handle smaller iteration counts than
    IFN_STORE_LANES can, but we don't have the infrastructure to choose
    reliably based on that.

    gcc/
            PR tree-optimization/99873
            * tree-vect-slp.c (vect_slp_prefer_store_lanes_p): New function.
            (vect_build_slp_instance): Don't split store groups that could
            use IFN_STORE_LANES.

    gcc/testsuite/
            * gcc.dg/vect/slp-21.c: Only expect 2 of the loops to use SLP
            if IFN_STORE_LANES is available.
            * gcc.dg/vect/vect-complex-5.c: Expect no loops to use SLP if
            IFN_STORE_LANES is available.
            * gcc.target/aarch64/pr99873_1.c: New test.
            * gcc.target/aarch64/pr99873_2.c: Likewise.
            * gcc.target/aarch64/pr99873_3.c: Likewise.
            * gcc.target/aarch64/sve/pr99873_1.c: Likewise.
            * gcc.target/aarch64/sve/pr99873_2.c: Likewise.
            * gcc.target/aarch64/sve/pr99873_3.c: Likewise.

  parent reply	other threads:[~2021-04-07 14:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01 18:19 [Bug tree-optimization/99873] New: " rsandifo at gcc dot gnu.org
2021-04-01 18:38 ` [Bug tree-optimization/99873] " rsandifo at gcc dot gnu.org
2021-04-06  7:34 ` rguenth at gcc dot gnu.org
2021-04-06  8:46 ` rsandifo at gcc dot gnu.org
2021-04-07 14:22 ` cvs-commit at gcc dot gnu.org [this message]
2021-04-07 18:04 ` rsandifo at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-99873-4-EOnCoogqvi@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).