From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 6B37F3858418; Wed, 17 Jan 2024 13:58:33 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B37F3858418
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1705499913;
	bh=oc4Rero3ggZpRYMf9ei1Ep5m1HGXCblhyCN/mExC5FQ=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=fFqSeKXKX8uJ2wXSO/p4M9PxaXMj/oT/TkcT2QkOnpJCP4DDAOPNIelw7+acaFaCK
	 AMsX/rSkqgcI+GF6aaSj8pL4vhCoGqmCX4rNku2UgWX8BqLEoCJUd/b9W+cMPVCPpa
	 BipbD5E+blJNoT0tyN7OwpFr05Q2Zj86hsuo12rk=
From: "matz at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/99888] Add powerpc ELFv2 support for
 -fpatchable-function-entry*
Date: Wed, 17 Jan 2024 13:58:30 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: matz at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: linkw at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-99888-4-pfIcE8Pff9@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99888-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99888-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99888

Michael Matz <matz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matz at gcc dot gnu.org

--- Comment #15 from Michael Matz <matz at gcc dot gnu.org> ---
Umm.  I just noticed this one as we now try to implement userspace live
patching
for ppc64le.  The point of the "before" NOPs is (and always was) that they =
are
completely out of the way of patchable but as-of-yet unpatched functions.

For ppc that means the "before" and "after" NOPs cannot be consecutive.  The
two
NOP sets being consecutive was never a design criteria or requirement.

So, while the original bug is fixed by what was committed (local entry was
skipping the patching-nops), the chosen solution is exactly the wrong one :=
-/=