public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/99912] Unnecessary / inefficient spilling of AVX2 ymm registers Date: Tue, 06 Apr 2021 08:25:24 +0000 [thread overview] Message-ID: <bug-99912-4-3yph6Qu9mZ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-99912-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99912 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rguenth at gcc dot gnu.org Keywords| |missed-optimization Target| |x86_64-*-* --- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> --- Which function does the loop kernel reside in? I see you have some lambdas in Z4c_RHS, done fancy as out-of-line functions, that do look like they could comprise the actual kernels. In apply_upwind_diss I see cases without stack usage. I'm looking at -O2 -march=skylake compiles Note that with C++ it's easy to retain some abstraction and thus misinterpret stack accesses as spilling where they are aggregates not eliminated. For example in one of the lambdas I see _61489 = __builtin_ia32_maskloadpd256 (_104487, _61513); D.545024[1].elts.car = _61489; ... MEM[(struct vect *)&D.544982].elts._M_elems[1] = MEM[(const struct simd &)&D.545024 + 32]; ... MEM[(struct mat3 *)&vars + 992B] = MEM[(const struct mat3 &)&D.544982]; and D.544982 is later variable indexed in some MIN/MAX, FMA using code (instead of using 'vars' there). Looking at what -fdump-tree-optimized produces is sometimes pointing at problems. That said, the code is large so please point at some source lines within the important kernel(s) (of the preprocessed source, that is) and the compile options used.
next prev parent reply other threads:[~2021-04-06 8:25 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-05 1:53 [Bug target/99912] New: " schnetter at gmail dot com 2021-04-05 1:54 ` [Bug target/99912] " schnetter at gmail dot com 2021-04-05 2:03 ` schnetter at gmail dot com 2021-04-06 8:25 ` rguenth at gcc dot gnu.org [this message] 2021-04-06 14:42 ` schnetter at gmail dot com 2021-04-06 16:33 ` schnetter at gmail dot com 2021-04-07 9:36 ` rguenth at gcc dot gnu.org 2021-04-07 16:48 ` rguenth at gcc dot gnu.org 2021-04-27 13:17 ` cvs-commit at gcc dot gnu.org 2021-04-27 13:17 ` cvs-commit at gcc dot gnu.org 2021-04-27 14:02 ` rguenth at gcc dot gnu.org 2021-04-27 16:03 ` schnetter at gmail dot com 2021-04-29 6:32 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-99912-4-3yph6Qu9mZ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).