From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 4A35E383B416; Sat, 29 May 2021 08:08:09 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A35E383B416
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/99928] [OpenMP] reduction variable in combined
 target construct wrongly mapped as firstprivate
Date: Sat, 29 May 2021 08:08:08 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: openmp, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-99928-4-AVXk6pFXUk@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99928-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99928-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 29 May 2021 08:08:09 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99928

--- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:5d21c0cbda0c4b109366f51534f328145da4c21f

commit r12-1119-g5d21c0cbda0c4b109366f51534f328145da4c21f
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat May 29 10:05:38 2021 +0200

    openmp: Add shared to parallel for linear on parallel master taskloop s=
imd
[PR99928]

    I forgot to add default(none) and defaultmap(none) wherever possible on=
 the
    testcases to make sure none of the required clauses are added implicitly
(because
    in that case it doesn't work with these none arguments of those default*
clauses
    or works differently with other default* settings.

    And that revealed we didn't add shared on parallel for linear clause
    on parallel master taskloop simd, so this patch fixes that too.

    2021-05-29  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/99928
            * gimplify.c (gimplify_scan_omp_clauses): For taskloop simd
            combined with parallel, make sure to add shared clause to
            parallel for explicit linear clause.

            * c-c++-common/gomp/pr99928-1.c: Add default(none) to constructs
            combined with parallel, teams or taskloop and defaultmap(none)
            to constructs combined with target.
            * c-c++-common/gomp/pr99928-2.c: Likewise.
            * c-c++-common/gomp/pr99928-3.c: Likewise.
            * c-c++-common/gomp/pr99928-4.c: Likewise.
            * c-c++-common/gomp/pr99928-5.c: Likewise.
            * c-c++-common/gomp/pr99928-6.c: Likewise.
            * c-c++-common/gomp/pr99928-7.c: Likewise.
            * c-c++-common/gomp/pr99928-8.c: Likewise.
            * c-c++-common/gomp/pr99928-9.c: Likewise.
            * c-c++-common/gomp/pr99928-10.c: Likewise.
            * c-c++-common/gomp/pr99928-13.c: Likewise.
            * c-c++-common/gomp/pr99928-14.c: Likewise.=