From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 1A577388981B; Tue,  1 Jun 2021 10:48:24 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A577388981B
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/99928] [OpenMP] reduction variable in combined
 target construct wrongly mapped as firstprivate
Date: Tue, 01 Jun 2021 10:48:23 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: openmp, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-99928-4-r8EJtmnZ6Q@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-99928-4@http.gcc.gnu.org/bugzilla/>
References: <bug-99928-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Jun 2021 10:48:24 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99928

--- Comment #16 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:f6bf436d9ab907d090823895abb7a2d5ba7ff50c

commit r12-1139-gf6bf436d9ab907d090823895abb7a2d5ba7ff50c
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Tue Jun 1 12:46:37 2021 +0200

    Fortran/OpenMP: Support (parallel) master taskloop (simd) [PR99928]

            PR middle-end/99928

    gcc/fortran/ChangeLog:

            * dump-parse-tree.c (show_omp_node, show_code_node): Handle
            (parallel) master taskloop (simd).
            * frontend-passes.c (gfc_code_walker): Set in_omp_workshare
            to false for parallel master taskloop (simd).
            * gfortran.h (enum gfc_statement):
            Add ST_OMP_(END_)(PARALLEL_)MASTER_TASKLOOP(_SIMD).
            (enum gfc_exec_op): EXEC_OMP_(PARALLEL_)MASTER_TASKLOOP(_SIMD).
            * match.h (gfc_match_omp_master_taskloop,
            gfc_match_omp_master_taskloop_simd,
            gfc_match_omp_parallel_master_taskloop,
            gfc_match_omp_parallel_master_taskloop_simd): New prototype.
            * openmp.c (gfc_match_omp_parallel_master_taskloop,
            gfc_match_omp_parallel_master_taskloop_simd,
            gfc_match_omp_master_taskloop,
            gfc_match_omp_master_taskloop_simd): New.
            (gfc_match_omp_taskloop_simd): Permit 'reduction' clause.
            (resolve_omp_clauses): Handle new combined directives; remove
            inscan-reduction check to reduce multiple errors; add
            task-reduction error for 'taskloop simd'.
            (gfc_resolve_omp_parallel_blocks,
            resolve_omp_do, omp_code_to_statement,
            gfc_resolve_omp_directive): Handle new combined constructs.
            * parse.c (decode_omp_directive, next_statement,
            gfc_ascii_statement, parse_omp_do, parse_omp_structured_block,
            parse_executable): Likewise.
            * resolve.c (gfc_resolve_blocks, gfc_resolve_code): Likewise.
            * st.c (gfc_free_statement): Likewise.
            * trans.c (trans_code): Likewise.
            * trans-openmp.c (gfc_split_omp_clauses,
            gfc_trans_omp_directive): Likewise.
            (gfc_trans_omp_parallel_master): Move after
gfc_trans_omp_master_taskloop;
            handle parallel master taskloop (simd) as well.
            (gfc_trans_omp_taskloop): Take gfc_exec_op as arg.
            (gfc_trans_omp_master_taskloop): New.

    gcc/testsuite/ChangeLog:

            * gfortran.dg/gomp/reduction5.f90: Remove dg-error; the issue is
            now diagnosed with less error output.
            * gfortran.dg/gomp/scan-1.f90: Likewise.
            * gfortran.dg/gomp/pr99928-3.f90: New test.
            * gfortran.dg/gomp/taskloop-1.f90: New test.=