From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 1219D386EC55; Wed,  7 Apr 2021 06:46:19 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1219D386EC55
From: "roland.illig at gmx dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/99950] New: Option -Wchar-subscripts leads to wrong fixes
Date: Wed, 07 Apr 2021 06:46:18 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: roland.illig at gmx dot de
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-99950-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Apr 2021 06:46:19 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D99950

            Bug ID: 99950
           Summary: Option -Wchar-subscripts leads to wrong fixes
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: roland.illig at gmx dot de
  Target Milestone: ---

When code calls the functions from <ctype.h> with an expression of type 'ch=
ar',
GCC and Clang warn:

> array subscript has type char

Since the function prototypes expect an 'int', inexperienced programmers ca=
st
the argument to 'int', which silences the warning:

https://github.com/search?q=3D%22isspace+int%22&type=3Dcode

More experienced programmers who heard something about 'unsigned' cast the
argument to 'unsigned int', which silences the warning as well:

https://github.com/search?q=3D%22isspace+unsigned+int%22&type=3Dcode

To get these programmers to fix their code properly, GCC should provide more
guidance in this area.  As a quick prototype I implemented a check for these
wrong "fixes" in NetBSD's lint, which results in warnings like these:

warning: argument to 'function from <ctype.h>' must be cast to 'unsigned ch=
ar',
not to 'int' [342]

The implementation is here, including a test:

https://github.com/NetBSD/src/blob/fdd2c09ca474/usr.bin/xlint/lint1/ckctype=
.c
https://github.com/NetBSD/src/blob/fdd2c09ca474/tests/usr.bin/xlint/lint1/m=
sg_341.c
https://github.com/NetBSD/src/blob/fdd2c09ca474/tests/usr.bin/xlint/lint1/m=
sg_341.exp

Maybe GCC can implement a similar check to prevent these wrong fixes in the
future.=