public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/99989] [11 regression] False maybe-uninitialized warning breaks bootstrap on riscv64
Date: Fri, 09 Apr 2021 10:57:49 +0000 [thread overview]
Message-ID: <bug-99989-4-tgVz4ewoxE@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-99989-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99989
--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #4)
> So perhaps just:
> --- gcc/gimple-ssa-warn-alloca.c.jj 2021-01-04 10:25:38.892233156 +0100
> +++ gcc/gimple-ssa-warn-alloca.c 2021-04-09 12:46:27.466847728 +0200
> @@ -124,9 +124,8 @@ public:
> alloca_type_and_limit (enum alloca_type type,
> wide_int i) : type(type), limit(i) { }
> alloca_type_and_limit (enum alloca_type type) : type(type)
> - { if (type == ALLOCA_BOUND_MAYBE_LARGE
> - || type == ALLOCA_BOUND_DEFINITELY_LARGE)
> - limit = wi::to_wide (integer_zero_node);
> + {
> + limit = wi::to_wide (integer_zero_node);
> }
> };
>
> in this case? Explicitly trying to have limit member conditionally
> uninitialized seems like a bad idea to me.
Yes, that looks good - the existing code is definitely odd, but maybe Martin
can clarify.
next prev parent reply other threads:[~2021-04-09 10:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 10:16 [Bug middle-end/99989] New: " schwab@linux-m68k.org
2021-04-09 10:17 ` [Bug middle-end/99989] " schwab@linux-m68k.org
2021-04-09 10:36 ` jakub at gcc dot gnu.org
2021-04-09 10:40 ` rguenth at gcc dot gnu.org
2021-04-09 10:47 ` rsandifo at gcc dot gnu.org
2021-04-09 10:48 ` jakub at gcc dot gnu.org
2021-04-09 10:57 ` rguenth at gcc dot gnu.org [this message]
2021-04-09 15:57 ` msebor at gcc dot gnu.org
2021-04-09 17:50 ` [Bug middle-end/99989] [11 regression] -Wmaybe-uninitialized " msebor at gcc dot gnu.org
2021-04-10 10:48 ` cvs-commit at gcc dot gnu.org
2021-04-10 10:50 ` jakub at gcc dot gnu.org
2021-04-10 11:07 ` schwab@linux-m68k.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-99989-4-tgVz4ewoxE@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).