Re: [STL] stl_construct.h: wrong comparison

Re: [STL] stl_construct.h: wrong comparison

[Ulrich Drepper]

jmaurer@menuett.rhein-main.de (Jens Maurer) writes:

> Note that this function requires forward iterators (only), but
> erroneously uses "first < last", which is only valid for
> random access iterators.

You are right.  I've fixed this now.  Thanks,

-- 
---------------.      drepper at gnu.org  ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Cygnus Solutions `--' drepper at cygnus.com   `------------------------

[STL] stl_construct.h: wrong comparison

[Jens Maurer]

Regarding the STL implementation of egcs-1.1.1 release,
there seems to be a bug in stl_construct.h in the following
code:

template <class ForwardIterator>
inline void
__destroy_aux(ForwardIterator first, ForwardIterator last, __false_type)
{
  for ( ; first < last; ++first)
    destroy(&*first);
}

Note that this function requires forward iterators (only), but
erroneously uses "first < last", which is only valid for
random access iterators.

The code should read

...
   for ( ; first != last; ++first) 
...


Other occurrences of the text "first < last" seem to be correct,
as they deal with random access iterators:

> grep "first < last" /usr/local/include/g++/*

Jens Maurer.