public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/vendors/redhat/heads/gcc-9-branch)] backport: re PR target/92723 (ICE in expand_shift_1, at expmed.c:2635)
@ 2020-01-23 10:16 Jakub Jelinek
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Jelinek @ 2020-01-23 10:16 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:86a5b74ed42dd1328f891e53bbe274108cbd1a76
commit 86a5b74ed42dd1328f891e53bbe274108cbd1a76
Author: Jakub Jelinek <jakub@redhat.com>
Date: Fri Dec 20 18:41:17 2019 +0100
backport: re PR target/92723 (ICE in expand_shift_1, at expmed.c:2635)
Backported from mainline
2019-12-11 Jakub Jelinek <jakub@redhat.com>
PR target/92723
* tree-vect-patterns.c (vect_recog_rotate_pattern): If dt is not
vect_internal_def, use oprnd1 as is, without trying to cast it.
Formatting fix.
* gcc.dg/vect/pr92723.c: New test.
From-SVN: r279671
Diff:
---
gcc/ChangeLog | 7 +++++++
gcc/testsuite/gcc.dg/vect/pr92723.c | 9 +++++++++
gcc/tree-vect-patterns.c | 15 +++------------
3 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index fd856d9..28ec878 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -5,6 +5,13 @@
diagnose teams not closely nested inside of target.
Backported from mainline
+ 2019-12-11 Jakub Jelinek <jakub@redhat.com>
+
+ PR target/92723
+ * tree-vect-patterns.c (vect_recog_rotate_pattern): If dt is not
+ vect_internal_def, use oprnd1 as is, without trying to cast it.
+ Formatting fix.
+
2019-11-27 Jakub Jelinek <jakub@redhat.com>
PR debug/92664
diff --git a/gcc/testsuite/gcc.dg/vect/pr92723.c b/gcc/testsuite/gcc.dg/vect/pr92723.c
new file mode 100644
index 0000000..0d60883
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/vect/pr92723.c
@@ -0,0 +1,9 @@
+/* { dg-do compile } */
+
+void
+foo (unsigned long long *x, unsigned long long *y, int z)
+{
+ int i;
+ for (i = 0; i < 1024; i++)
+ x[i] = (y[i] >> z) | (y[i] << (-z & (__SIZEOF_LONG_LONG__ * __CHAR_BIT__ - 1)));
+}
diff --git a/gcc/tree-vect-patterns.c b/gcc/tree-vect-patterns.c
index ff952d6..badf4e7 100644
--- a/gcc/tree-vect-patterns.c
+++ b/gcc/tree-vect-patterns.c
@@ -2070,14 +2070,12 @@ vect_recog_rotate_pattern (stmt_vec_info stmt_vinfo, tree *type_out)
*type_out = vectype;
- if (dt == vect_external_def
- && TREE_CODE (oprnd1) == SSA_NAME)
+ if (dt == vect_external_def && TREE_CODE (oprnd1) == SSA_NAME)
ext_def = vect_get_external_def_edge (vinfo, oprnd1);
def = NULL_TREE;
scalar_int_mode mode = SCALAR_INT_TYPE_MODE (type);
- if (TREE_CODE (oprnd1) == INTEGER_CST
- || TYPE_MODE (TREE_TYPE (oprnd1)) == mode)
+ if (dt != vect_internal_def || TYPE_MODE (TREE_TYPE (oprnd1)) == mode)
def = oprnd1;
else if (def_stmt && gimple_assign_cast_p (def_stmt))
{
@@ -2092,14 +2090,7 @@ vect_recog_rotate_pattern (stmt_vec_info stmt_vinfo, tree *type_out)
{
def = vect_recog_temp_ssa_var (type, NULL);
def_stmt = gimple_build_assign (def, NOP_EXPR, oprnd1);
- if (ext_def)
- {
- basic_block new_bb
- = gsi_insert_on_edge_immediate (ext_def, def_stmt);
- gcc_assert (!new_bb);
- }
- else
- append_pattern_def_seq (stmt_vinfo, def_stmt);
+ append_pattern_def_seq (stmt_vinfo, def_stmt);
}
stype = TREE_TYPE (def);
scalar_int_mode smode = SCALAR_INT_TYPE_MODE (stype);
^ permalink raw reply [flat|nested] 2+ messages in thread
* [gcc(refs/vendors/redhat/heads/gcc-9-branch)] backport: re PR target/92723 (ICE in expand_shift_1, at expmed.c:2635)
@ 2020-01-23 10:13 Jakub Jelinek
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Jelinek @ 2020-01-23 10:13 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:40f81c264350a4551ad9c2cae7d5c3d157ee8d32
commit 40f81c264350a4551ad9c2cae7d5c3d157ee8d32
Author: Jakub Jelinek <jakub@redhat.com>
Date: Fri Dec 20 18:41:17 2019 +0100
backport: re PR target/92723 (ICE in expand_shift_1, at expmed.c:2635)
Backported from mainline
2019-12-11 Jakub Jelinek <jakub@redhat.com>
PR target/92723
* tree-vect-patterns.c (vect_recog_rotate_pattern): If dt is not
vect_internal_def, use oprnd1 as is, without trying to cast it.
Formatting fix.
* gcc.dg/vect/pr92723.c: New test.
Diff:
---
gcc/ChangeLog | 9 +++++++++
gcc/testsuite/gcc.dg/vect/pr92723.c | 9 +++++++++
gcc/tree-vect-patterns.c | 15 +++------------
3 files changed, 21 insertions(+), 12 deletions(-)
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index ed8d81a..5d334bb 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -5,6 +5,15 @@
diagnose teams not closely nested inside of target.
Backported from mainline
+ 2019-12-11 Jakub Jelinek <jakub@redhat.com>
+
+2019-12-20 Jakub Jelinek <jakub@redhat.com>
+
+ PR target/92723
+ * tree-vect-patterns.c (vect_recog_rotate_pattern): If dt is not
+ vect_internal_def, use oprnd1 as is, without trying to cast it.
+ Formatting fix.
+
2019-11-27 Jakub Jelinek <jakub@redhat.com>
PR debug/92664
diff --git a/gcc/testsuite/gcc.dg/vect/pr92723.c b/gcc/testsuite/gcc.dg/vect/pr92723.c
new file mode 100644
index 0000000..0d60883
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/vect/pr92723.c
@@ -0,0 +1,9 @@
+/* { dg-do compile } */
+
+void
+foo (unsigned long long *x, unsigned long long *y, int z)
+{
+ int i;
+ for (i = 0; i < 1024; i++)
+ x[i] = (y[i] >> z) | (y[i] << (-z & (__SIZEOF_LONG_LONG__ * __CHAR_BIT__ - 1)));
+}
diff --git a/gcc/tree-vect-patterns.c b/gcc/tree-vect-patterns.c
index ff952d6..badf4e7 100644
--- a/gcc/tree-vect-patterns.c
+++ b/gcc/tree-vect-patterns.c
@@ -2070,14 +2070,12 @@ vect_recog_rotate_pattern (stmt_vec_info stmt_vinfo, tree *type_out)
*type_out = vectype;
- if (dt == vect_external_def
- && TREE_CODE (oprnd1) == SSA_NAME)
+ if (dt == vect_external_def && TREE_CODE (oprnd1) == SSA_NAME)
ext_def = vect_get_external_def_edge (vinfo, oprnd1);
def = NULL_TREE;
scalar_int_mode mode = SCALAR_INT_TYPE_MODE (type);
- if (TREE_CODE (oprnd1) == INTEGER_CST
- || TYPE_MODE (TREE_TYPE (oprnd1)) == mode)
+ if (dt != vect_internal_def || TYPE_MODE (TREE_TYPE (oprnd1)) == mode)
def = oprnd1;
else if (def_stmt && gimple_assign_cast_p (def_stmt))
{
@@ -2092,14 +2090,7 @@ vect_recog_rotate_pattern (stmt_vec_info stmt_vinfo, tree *type_out)
{
def = vect_recog_temp_ssa_var (type, NULL);
def_stmt = gimple_build_assign (def, NOP_EXPR, oprnd1);
- if (ext_def)
- {
- basic_block new_bb
- = gsi_insert_on_edge_immediate (ext_def, def_stmt);
- gcc_assert (!new_bb);
- }
- else
- append_pattern_def_seq (stmt_vinfo, def_stmt);
+ append_pattern_def_seq (stmt_vinfo, def_stmt);
}
stype = TREE_TYPE (def);
scalar_int_mode smode = SCALAR_INT_TYPE_MODE (stype);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-23 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-23 10:16 [gcc(refs/vendors/redhat/heads/gcc-9-branch)] backport: re PR target/92723 (ICE in expand_shift_1, at expmed.c:2635) Jakub Jelinek
-- strict thread matches above, loose matches on Subject: below --
2020-01-23 10:13 Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).