From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1698) id 0DEE73947422; Wed, 18 Mar 2020 21:16:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0DEE73947422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1584566168; bh=XdAqc/kNSpQqhBDfpJgehyGL826XGeG9mxzves2NkJE=; h=From:To:Subject:Date:From; b=IrLy06BGXxZi6C7qingUncAvgOWH90+n4cqhIyOkM8YQ2dyFGKI9rLgsfIDZhXoLI Ns/fACEdEdV/mMMU2fPb36+AGXryDOvieWUJWOyftTZa0p0DtsOVYpNIU4NYVqtrSW iHMe2rpsqSDr9eRemDXxy0LK/WsmLwlWD2jXBJQs= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Iain D Sandoe To: gcc-cvs@gcc.gnu.org Subject: [gcc/devel/c++-coroutines] c++: Diagnose a deduction guide in a wrong scope [PR91759] X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/devel/c++-coroutines X-Git-Oldrev: 52b3aa8be18938486065f5f2a23553b134a10a81 X-Git-Newrev: af8656be8df68ac26840f7844430fd595255ebd2 Message-Id: <20200318211608.0DEE73947422@sourceware.org> Date: Wed, 18 Mar 2020 21:16:08 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2020 21:16:08 -0000 https://gcc.gnu.org/g:af8656be8df68ac26840f7844430fd595255ebd2 commit af8656be8df68ac26840f7844430fd595255ebd2 Author: Jakub Jelinek Date: Wed Mar 18 08:53:23 2020 +0100 c++: Diagnose a deduction guide in a wrong scope [PR91759] The following testcase is accepts-invalid since r7-6608-ga56c0ac08242269b. Before that change we had this "deduction guide %qD must be declared in the same scope as %qT" diagnostics for it, after the change it is expected to be diagnosed in set_decl_namespace at the not_found: label in there. On this testcase nothing is diagnosed though, because set_decl_namespace isn't called at all, as in_namespace is NULL. The following patch restores the old warning but does it only in case we don't call set_decl_namespace. 2020-03-18 Jakub Jelinek PR c++/91759 * decl.c (grokfndecl): Restore old diagnostics about deduction guide declared in different scope if in_namespace is NULL_TREE. * g++.dg/cpp1z/class-deduction72.C: New test. Diff: --- gcc/cp/ChangeLog | 6 ++++++ gcc/cp/decl.c | 9 +++++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/g++.dg/cpp1z/class-deduction72.C | 11 +++++++++++ 4 files changed, 31 insertions(+) diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 1db1e090e51..9aaa81a17bb 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2020-03-18 Jakub Jelinek + + PR c++/91759 + * decl.c (grokfndecl): Restore old diagnostics about deduction + guide declared in different scope if in_namespace is NULL_TREE. + 2020-03-17 Jakub Jelinek PR c++/90995 diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c index d240436d84a..319b7ee5c1c 100644 --- a/gcc/cp/decl.c +++ b/gcc/cp/decl.c @@ -9644,6 +9644,15 @@ grokfndecl (tree ctype, "namespace scope", decl); return NULL_TREE; } + tree type = TREE_TYPE (DECL_NAME (decl)); + if (in_namespace == NULL_TREE + && CP_DECL_CONTEXT (decl) != CP_TYPE_CONTEXT (type)) + { + error_at (location, "deduction guide %qD must be declared in the " + "same scope as %qT", decl, type); + inform (location_of (type), " declared here"); + return NULL_TREE; + } if (funcdef_flag) error_at (location, "deduction guide %qD must not have a function body", decl); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 775837d840f..8efb773437b 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2020-03-18 Jakub Jelinek + + PR c++/91759 + * g++.dg/cpp1z/class-deduction72.C: New test. + 2020-03-17 Uroš Bizjak * g++.dg/debug/dwarf2/const2b.C (dg-do): Fix target selector. diff --git a/gcc/testsuite/g++.dg/cpp1z/class-deduction72.C b/gcc/testsuite/g++.dg/cpp1z/class-deduction72.C new file mode 100644 index 00000000000..60c559907a3 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp1z/class-deduction72.C @@ -0,0 +1,11 @@ +// PR c++/91759 +// { dg-do compile { target c++17 } } + +namespace N { + template + struct X{ X(int); }; // { dg-message "declared here" } +} + +using N::X; + +X(int) -> X; // { dg-error "must be declared in the same scope as" }