public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/vendors/ibm/heads/perf)] aarch64: Fix another bug in aarch64_add_offset_1 [PR94121]
@ 2020-03-19 6:18 Jiu Fu Guo
0 siblings, 0 replies; only message in thread
From: Jiu Fu Guo @ 2020-03-19 6:18 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:7aa605c9d4643dc6e0a0460e5697c02457cd7278
commit 7aa605c9d4643dc6e0a0460e5697c02457cd7278
Author: Jakub Jelinek <jakub@redhat.com>
Date: Fri Mar 13 11:33:16 2020 +0100
aarch64: Fix another bug in aarch64_add_offset_1 [PR94121]
> I'm getting this ICE with -mabi=ilp32:
>
> during RTL pass: fwprop1
> /opt/gcc/gcc-20200312/gcc/testsuite/gcc.dg/pr94121.c: In function 'bar':
> /opt/gcc/gcc-20200312/gcc/testsuite/gcc.dg/pr94121.c:16:1: internal compiler error: in decompose, at rtl.h:2279
That is a preexisting issue, caused by another bug in the same function.
When mode is SImode and moffset is 0x80000000 (or anything else with the
bit 31 set), we need to sign-extend it.
2020-03-13 Jakub Jelinek <jakub@redhat.com>
PR target/94121
* config/aarch64/aarch64.c (aarch64_add_offset_1): Use gen_int_mode
instead of GEN_INT.
Diff:
---
gcc/ChangeLog | 6 ++++++
gcc/config/aarch64/aarch64.c | 3 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 25abfcfd70d..448c1e138fa 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2020-03-13 Jakub Jelinek <jakub@redhat.com>
+
+ PR target/94121
+ * config/aarch64/aarch64.c (aarch64_add_offset_1): Use gen_int_mode
+ instead of GEN_INT.
+
2020-03-13 H.J. Lu <hongjiu.lu@intel.com>
PR target/89229
diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index 2c81f86dd2a..b0cbb6e2d55 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -3757,7 +3757,8 @@ aarch64_add_offset_1 (scalar_int_mode mode, rtx dest,
if (emit_move_imm)
{
gcc_assert (temp1 != NULL_RTX || can_create_pseudo_p ());
- temp1 = aarch64_force_temporary (mode, temp1, GEN_INT (moffset));
+ temp1 = aarch64_force_temporary (mode, temp1,
+ gen_int_mode (moffset, mode));
}
insn = emit_insn (offset < 0
? gen_sub3_insn (dest, src, temp1)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-19 6:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-19 6:18 [gcc(refs/vendors/ibm/heads/perf)] aarch64: Fix another bug in aarch64_add_offset_1 [PR94121] Jiu Fu Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).