public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/vendors/redhat/heads/gcc-10-branch)] fortran: ICE using undeclared symbol in array constructor PR93484
@ 2020-03-25 10:13 Jakub Jelinek
0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2020-03-25 10:13 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:c38daa7976886a59a3cd496b5c776d75f3cdb056
commit c38daa7976886a59a3cd496b5c776d75f3cdb056
Author: Mark Eggleston <markeggleston@gcc.gnu.org>
Date: Wed Mar 25 08:33:03 2020 +0000
fortran: ICE using undeclared symbol in array constructor PR93484
Using undeclared symbol k in an expression in the following
array constructor results in an ICE:
print *, [real(x(k))]
If the call to the intrinsic is not in a constructor a no IMPLICIT
type error is reported and the ICE does not occur.
Matching on an expression instead of an initialisation express an
and not converting a MATCH_ERROR return value into MATCH_NO results
in the no IMPLICIT error and no ICE.
Note: Steven G. Kargl <kargl@gcc.gnu.org> is the author of the
changes except for the test cases.
gcc/fortran/ChangeLog:
PR fortran/93484
* match.c (gfc_match_type_spec): Replace gfc_match_init_expr with
gfc_match_expr. Return m if m is MATCH_NO or MATCH_ERROR.
gcc/testsuite
PR fortran/93484
* gfortran.dg/pr93484_1.f90: New test.
* gfortran.dg/pr93484_2.f90: New test.
Diff:
---
gcc/fortran/ChangeLog | 6 ++++++
gcc/fortran/match.c | 4 ++--
gcc/testsuite/ChangeLog | 6 ++++++
gcc/testsuite/gfortran.dg/pr93484_1.f90 | 8 ++++++++
gcc/testsuite/gfortran.dg/pr93484_2.f90 | 8 ++++++++
5 files changed, 30 insertions(+), 2 deletions(-)
diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog
index 05915791d86..0f6dab3b3c2 100644
--- a/gcc/fortran/ChangeLog
+++ b/gcc/fortran/ChangeLog
@@ -1,3 +1,9 @@
+2020-03-25 Steven G. Kargl <kargl@gcc.gnu.org>
+
+ PR fortran/93484
+ * match.c (gfc_match_type_spec): Replace gfc_match_init_expr with
+ gfc_match_expr. Return m if m is MATCH_NO or MATCH_ERROR.
+
2020-03-23 Mark Eggleston <mark.eggleston@codethink.com>
Steven G. Kargl <kargl@gcc.gnu.org>
diff --git a/gcc/fortran/match.c b/gcc/fortran/match.c
index 3a0c097325f..8443d20dc4f 100644
--- a/gcc/fortran/match.c
+++ b/gcc/fortran/match.c
@@ -2248,9 +2248,9 @@ gfc_match_type_spec (gfc_typespec *ts)
found:
- m = gfc_match_init_expr (&e);
+ m = gfc_match_expr (&e);
if (m == MATCH_NO || m == MATCH_ERROR)
- return MATCH_NO;
+ return m;
/* If a comma appears, it is an intrinsic subprogram. */
gfc_gobble_whitespace ();
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index b68779ff339..4711a09c224 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2020-03-25 Mark Eggleston <mark.eggleston@codethink.com>
+
+ PR fortran/93484
+ * gfortran.dg/pr93484_1.f90: New test.
+ * gfortran.dg/pr93484_2.f90: New test.
+
2020-03-25 Jakub Jelinek <jakub@redhat.com>
PR middle-end/94303
diff --git a/gcc/testsuite/gfortran.dg/pr93484_1.f90 b/gcc/testsuite/gfortran.dg/pr93484_1.f90
new file mode 100644
index 00000000000..3b6dbc9ad79
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr93484_1.f90
@@ -0,0 +1,8 @@
+! { dg-do compile }
+!
+program p
+ implicit none
+ integer :: x(4) = [1,2,3,4]
+ print *, [real(x(k))] ! { dg-error "Symbol 'k' at .1. has no IMPLICIT type" }
+end
+
diff --git a/gcc/testsuite/gfortran.dg/pr93484_2.f90 b/gcc/testsuite/gfortran.dg/pr93484_2.f90
new file mode 100644
index 00000000000..4a7f4330ed9
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr93484_2.f90
@@ -0,0 +1,8 @@
+! { dg-do compile }
+!
+program p
+ implicit none
+ integer, parameter :: x(4) = [1,2,3,4]
+ print *, [real(x(k))] ! { dg-error "Symbol 'k' at .1. has no IMPLICIT type" }
+end
+
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-25 10:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25 10:13 [gcc(refs/vendors/redhat/heads/gcc-10-branch)] fortran: ICE using undeclared symbol in array constructor PR93484 Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).