public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/guojiufu/heads/personal-branch)] contrib: Improve comments and error text
@ 2020-06-10 3:23 Jiu Fu Guo
0 siblings, 0 replies; only message in thread
From: Jiu Fu Guo @ 2020-06-10 3:23 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:9a8bac4d7e7209a1fef96a077c80bb2416aac6ce
commit 9a8bac4d7e7209a1fef96a077c80bb2416aac6ce
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Jun 2 08:38:31 2020 +0200
contrib: Improve comments and error text
* gcc-changelog/git_commit.py (GitCommit.check_mentioned_files):
Improve error text.
Diff:
---
contrib/gcc-changelog/git_commit.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py
index 4f82b58f64b..7fbc029408d 100755
--- a/contrib/gcc-changelog/git_commit.py
+++ b/contrib/gcc-changelog/git_commit.py
@@ -176,7 +176,7 @@ class Error:
class ChangeLogEntry:
def __init__(self, folder, authors, prs):
self.folder = folder
- # Python2 has not 'copy' function
+ # The 'list.copy()' function is not available before Python 3.3
self.author_lines = list(authors)
self.initial_prs = list(prs)
self.prs = list(prs)
@@ -209,7 +209,7 @@ class ChangeLogEntry:
line = line[:line.index(':')]
in_location = False
- # At this point, all that 's left is a list of filenames
+ # At this point, all that's left is a list of filenames
# separated by commas and whitespaces.
for file in line.split(','):
file = file.strip()
@@ -503,7 +503,7 @@ class GitCommit:
mentioned_files = set()
for entry in self.changelog_entries:
if not entry.files:
- msg = 'ChangeLog must contain a file entry'
+ msg = 'ChangeLog must contain at least one file entry'
self.errors.append(Error(msg, entry.folder))
assert not entry.folder.endswith('/')
for file in entry.files:
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-06-10 3:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-10 3:23 [gcc(refs/users/guojiufu/heads/personal-branch)] contrib: Improve comments and error text Jiu Fu Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).