public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/c++-modules] Fix missing assemble_external in ASM_OUTPUT_FDESC
@ 2020-06-11 13:12 Nathan Sidwell
  0 siblings, 0 replies; only message in thread
From: Nathan Sidwell @ 2020-06-11 13:12 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:9b4e77e807e0099c3cfbf9c5b0c9e4154b9cb7a0

commit 9b4e77e807e0099c3cfbf9c5b0c9e4154b9cb7a0
Author: Andreas Schwab <schwab@suse.de>
Date:   Fri May 15 17:38:30 2020 +0200

    Fix missing assemble_external in ASM_OUTPUT_FDESC
    
    When TARGET_VTABLE_USES_DESCRIPTORS is defined then function pointers in
    the vtable are output by ASM_OUTPUT_FDESC.  The only current user of
    this is ia64, but its implementation of ASM_OUTPUT_FDESC lacks a call to
    assemble_external.  Thus if there is no other reference to the function
    the weak declaration for it will be missing.
    
            PR target/95154
            * config/ia64/ia64.h (ASM_OUTPUT_FDESC): Call assemble_external.

Diff:
---
 gcc/config/ia64/ia64.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/config/ia64/ia64.h b/gcc/config/ia64/ia64.h
index 8462535d749..d5acc62cd87 100644
--- a/gcc/config/ia64/ia64.h
+++ b/gcc/config/ia64/ia64.h
@@ -963,6 +963,7 @@ do {									\
 do {									\
   if ((PART) == 0)							\
     {									\
+      assemble_external (DECL);						\
       if (TARGET_ILP32)							\
         fputs ("\tdata8.ua @iplt(", FILE);				\
       else								\


^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2020-06-11 13:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11 13:12 [gcc/devel/c++-modules] Fix missing assemble_external in ASM_OUTPUT_FDESC Nathan Sidwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).