public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/guojiufu/heads/guojiufu-branch)] gcc-changelog: add more Review by prefixes.
@ 2020-06-13  2:49 Jiu Fu Guo
  0 siblings, 0 replies; only message in thread
From: Jiu Fu Guo @ 2020-06-13  2:49 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:771e60dd073b4dc0663fa9282b854dafdd92242d

commit 771e60dd073b4dc0663fa9282b854dafdd92242d
Author: Martin Liska <mliska@suse.cz>
Date:   Wed Jun 10 09:57:51 2020 +0200

    gcc-changelog: add more Review by prefixes.
    
    contrib/ChangeLog:
    
            * gcc-changelog/git_commit.py: Add more supported prefixes.
            * gcc-changelog/test_email.py: Fix one flake8 error.
            * gcc-changelog/test_patches.txt: Add tested for newly
            supported prefixes.

Diff:
---
 contrib/gcc-changelog/git_commit.py    | 8 +++-----
 contrib/gcc-changelog/test_email.py    | 5 +++--
 contrib/gcc-changelog/test_patches.txt | 4 ++++
 3 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py
index 0b350ba7fda..eac64887053 100755
--- a/contrib/gcc-changelog/git_commit.py
+++ b/contrib/gcc-changelog/git_commit.py
@@ -159,12 +159,10 @@ LINE_LIMIT = 100
 TAB_WIDTH = 8
 CO_AUTHORED_BY_PREFIX = 'co-authored-by: '
 CHERRY_PICK_PREFIX = '(cherry picked from commit '
-REVIEWED_BY_PREFIX = 'reviewed-by: '
-REVIEWED_ON_PREFIX = 'reviewed-on: '
-SIGNED_OFF_BY_PREFIX = 'signed-off-by: '
 
-REVIEW_PREFIXES = (REVIEWED_BY_PREFIX, REVIEWED_ON_PREFIX,
-                   SIGNED_OFF_BY_PREFIX)
+REVIEW_PREFIXES = ('reviewed-by: ', 'reviewed-on: ', 'signed-off-by: ',
+                   'acked-by: ', 'tested-by: ', 'reported-by: ',
+                   'suggested-by: ')
 
 
 class Error:
diff --git a/contrib/gcc-changelog/test_email.py b/contrib/gcc-changelog/test_email.py
index df57bb5c94a..c50687bc331 100755
--- a/contrib/gcc-changelog/test_email.py
+++ b/contrib/gcc-changelog/test_email.py
@@ -161,8 +161,9 @@ class TestGccChangelog(unittest.TestCase):
 
     def test_additional_author_list(self):
         email = self.from_patch_glob('0342')
-        assert (email.errors[1].message == 'additional author must be indented '
-                                           'with one tab and four spaces')
+        msg = 'additional author must be indented ' \
+              'with one tab and four spaces'
+        assert email.errors[1].message == msg
 
     def test_trailing_whitespaces(self):
         email = self.get_git_email('trailing-whitespaces.patch')
diff --git a/contrib/gcc-changelog/test_patches.txt b/contrib/gcc-changelog/test_patches.txt
index 15fe0df1ccc..1dec932f783 100644
--- a/contrib/gcc-changelog/test_patches.txt
+++ b/contrib/gcc-changelog/test_patches.txt
@@ -2430,6 +2430,10 @@ Signed-off-by: Keith Packard <keithp@keithp.com>
 Reviewed-by: Keith Packard <keithp@keithp.com>
 Reviewed-on: Keith Packard <keithp@keithp.com>
 Co-Authored-by: Keith Packard <keithp@keithp.com>
+Acked-By: Keith Packard <keithp@keithp.com>
+Tested-by: Keith Packard <keithp@keithp.com>
+Reported-by: Keith Packard <keithp@keithp.com>
+Suggested-by: Keith Packard <keithp@keithp.com>
 ---
  gcc/ChangeLog            |  5 +++++
  gcc/config/riscv/riscv.c | 40 ++++++++++++++++++++++++++++++++++++++++


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-13  2:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-13  2:49 [gcc(refs/users/guojiufu/heads/guojiufu-branch)] gcc-changelog: add more Review by prefixes Jiu Fu Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).