public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Giuliano Belinassi <giulianob@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc/devel/autopar_devel] [Ada] ICE during unnesting when nested subprograms have address taken
Date: Sat, 22 Aug 2020 21:50:19 +0000 (GMT)	[thread overview]
Message-ID: <20200822215019.763A53983056@sourceware.org> (raw)

https://gcc.gnu.org/g:853aefaf80da5a7c4818736802cd1e6e3fd5be4a

commit 853aefaf80da5a7c4818736802cd1e6e3fd5be4a
Author: Gary Dismukes <dismukes@adacore.com>
Date:   Thu Dec 19 17:00:27 2019 -0500

    [Ada] ICE during unnesting when nested subprograms have address taken
    
    2020-06-02  Gary Dismukes  <dismukes@adacore.com>
    
    gcc/ada/
    
            * exp_unst.adb (Register_Subprogram): Test for Address_Taken (in
            addition to the existing test for In_Synchonized_Unit) when
            deciding whether to reset the Reachable flag on all subprograms
            enclosing the subprogram being registered.

Diff:
---
 gcc/ada/exp_unst.adb | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/gcc/ada/exp_unst.adb b/gcc/ada/exp_unst.adb
index 1460b641b19..b3ded138ee5 100644
--- a/gcc/ada/exp_unst.adb
+++ b/gcc/ada/exp_unst.adb
@@ -841,9 +841,13 @@ package body Exp_Unst is
 
                --  If we marked this reachable because it's in a synchronized
                --  unit, we have to mark all enclosing subprograms as reachable
-               --  as well.
+               --  as well. We do the same for subprograms with Address_Taken,
+               --  because otherwise we can run into problems with looking at
+               --  enclosing subprograms in Subps.Table due to their being
+               --  unreachable (the Subp_Index of unreachable subps is later
+               --  set to zero and their entry in Subps.Table is removed).
 
-               if In_Synchronized_Unit (E) then
+               if In_Synchronized_Unit (E) or else Address_Taken (E) then
                   declare
                      S : Entity_Id := E;


                 reply	other threads:[~2020-08-22 21:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200822215019.763A53983056@sourceware.org \
    --to=giulianob@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).