public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/autopar_devel] [Ada] Missing error on aspects Input and Output
@ 2020-08-22 22:47 Giuliano Belinassi
0 siblings, 0 replies; only message in thread
From: Giuliano Belinassi @ 2020-08-22 22:47 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:bf2e23abc4d57409322005d21ad4e5a0fbf2948a
commit bf2e23abc4d57409322005d21ad4e5a0fbf2948a
Author: Javier Miranda <miranda@adacore.com>
Date: Tue Apr 21 09:22:28 2020 -0400
[Ada] Missing error on aspects Input and Output
2020-06-18 Javier Miranda <miranda@adacore.com>
gcc/ada/
* sem_ch13.adb (Has_Good_Profile): Enforce strictness in the
check. Required to detect wrong profiles for Input and Output.
(Analyze_Stream_TSS_Definition): Minor enhancement in the text
of the error for class-wide attributes.
Diff:
---
gcc/ada/sem_ch13.adb | 33 ++++++++++-----------------------
1 file changed, 10 insertions(+), 23 deletions(-)
diff --git a/gcc/ada/sem_ch13.adb b/gcc/ada/sem_ch13.adb
index 3a0a4b2331d..5318fc61603 100644
--- a/gcc/ada/sem_ch13.adb
+++ b/gcc/ada/sem_ch13.adb
@@ -5019,33 +5019,14 @@ package body Sem_Ch13 is
Typ := Etype (F);
- -- If the attribute specification comes from an aspect
- -- specification for a class-wide stream, the parameter must be
- -- a class-wide type of the entity to which the aspect applies.
-
- if From_Aspect_Specification (N)
- and then Class_Present (Parent (N))
- and then Is_Class_Wide_Type (Typ)
- then
- Typ := Etype (Typ);
- end if;
-
else
Typ := Etype (Subp);
end if;
-- Verify that the prefix of the attribute and the local name for
- -- the type of the formal match, or one is the class-wide of the
- -- other, in the case of a class-wide stream operation.
-
- if Base_Type (Typ) = Base_Type (Ent)
- or else (Is_Class_Wide_Type (Typ)
- and then Typ = Class_Wide_Type (Base_Type (Ent)))
- or else (Is_Class_Wide_Type (Ent)
- and then Ent = Class_Wide_Type (Base_Type (Typ)))
- then
- null;
- else
+ -- the type of the formal match.
+
+ if Base_Type (Typ) /= Base_Type (Ent) then
return False;
end if;
@@ -5158,7 +5139,13 @@ package body Sem_Ch13 is
else
Error_Msg_Name_1 := Attr;
- Error_Msg_N ("incorrect expression for% attribute", Expr);
+
+ if Is_Class_Wide_Type (Base_Type (Ent)) then
+ Error_Msg_N
+ ("incorrect expression for class-wide% attribute", Expr);
+ else
+ Error_Msg_N ("incorrect expression for% attribute", Expr);
+ end if;
end if;
end Analyze_Stream_TSS_Definition;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-08-22 22:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-22 22:47 [gcc/devel/autopar_devel] [Ada] Missing error on aspects Input and Output Giuliano Belinassi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).