public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/autopar_devel] [Ada] Add comments about attribute 'Valid_Scalars on private tagged types
@ 2020-08-22 22:51 Giuliano Belinassi
0 siblings, 0 replies; only message in thread
From: Giuliano Belinassi @ 2020-08-22 22:51 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:7012abc11bf3e6bfb8a605f066cd3771459d2446
commit 7012abc11bf3e6bfb8a605f066cd3771459d2446
Author: Piotr Trojanek <trojanek@adacore.com>
Date: Mon Apr 27 11:30:06 2020 +0200
[Ada] Add comments about attribute 'Valid_Scalars on private tagged types
2020-06-19 Piotr Trojanek <trojanek@adacore.com>
gcc/ada/
* exp_attr.adb (Expand_N_Attribute_Reference): Add comment.
* sem_attr.adb (Analyze_Attribute): Add ??? comment.
* sem_util.ads (Valid_Scalars): This routine is only used for
'Valid_Scalars and not for 'Valid.
Diff:
---
gcc/ada/exp_attr.adb | 3 ++-
gcc/ada/sem_attr.adb | 4 ++++
gcc/ada/sem_util.ads | 8 ++++----
3 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/gcc/ada/exp_attr.adb b/gcc/ada/exp_attr.adb
index 0eead444759..84a36f89a26 100644
--- a/gcc/ada/exp_attr.adb
+++ b/gcc/ada/exp_attr.adb
@@ -7094,7 +7094,8 @@ package body Exp_Attr is
Expr := Empty;
- -- Attribute 'Valid_Scalars is not supported on private tagged types
+ -- Attribute 'Valid_Scalars is not supported on private tagged types;
+ -- see a detailed explanation where this attribute is analyzed.
if Is_Private_Type (Ptyp) and then Is_Tagged_Type (Ptyp) then
null;
diff --git a/gcc/ada/sem_attr.adb b/gcc/ada/sem_attr.adb
index bf45fb84c3b..3bd87fdf3db 100644
--- a/gcc/ada/sem_attr.adb
+++ b/gcc/ada/sem_attr.adb
@@ -7016,6 +7016,10 @@ package body Sem_Attr is
-- types due to a code generation issue. Is_Visible_Component
-- does not allow for a component of a private tagged type to
-- be successfully retrieved.
+ -- ??? This attribute should simply ignore type privacy
+ -- (see Validated_View). It should examine components of the
+ -- tagged type extensions (if any) and recursively examine
+ -- 'Valid_Scalars of the parent's type (if any).
-- Do not use Error_Attr_P because this bypasses any subsequent
-- processing and leaves the attribute with type Any_Type. This
diff --git a/gcc/ada/sem_util.ads b/gcc/ada/sem_util.ads
index 7a54b5c52dc..d99edeaa902 100644
--- a/gcc/ada/sem_util.ads
+++ b/gcc/ada/sem_util.ads
@@ -3050,10 +3050,10 @@ package Sem_Util is
-- conversions, and unchecked conversions.
function Validated_View (Typ : Entity_Id) return Entity_Id;
- -- Obtain the "validated view" of arbitrary type Typ which is suitable
- -- for verification by attributes 'Valid and 'Valid_Scalars. This view
- -- is the type itself or its full view while stripping away concurrency,
- -- derivations, and privacy.
+ -- Obtain the "validated view" of arbitrary type Typ which is suitable for
+ -- verification by attributes 'Valid_Scalars. This view is the type itself
+ -- or its full view while stripping away concurrency, derivations, and
+ -- privacy.
function Visible_Ancestors (Typ : Entity_Id) return Elist_Id;
-- [Ada 2012:AI-0125-1]: Collect all the visible parents and progenitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-08-22 22:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-22 22:51 [gcc/devel/autopar_devel] [Ada] Add comments about attribute 'Valid_Scalars on private tagged types Giuliano Belinassi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).