public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc/devel/autopar_devel] c++: Partially revert fix for PR c++/95497 [PR96132]
@ 2020-08-22 23:29 Giuliano Belinassi
0 siblings, 0 replies; only message in thread
From: Giuliano Belinassi @ 2020-08-22 23:29 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:9872b77784d7d71f6d458ef11f0af6ad772a7dff
commit 9872b77784d7d71f6d458ef11f0af6ad772a7dff
Author: Patrick Palka <ppalka@redhat.com>
Date: Thu Jul 9 13:47:13 2020 -0400
c++: Partially revert fix for PR c++/95497 [PR96132]
I was mistaken to assume that a dependent type is necessarily
incomplete, and indeed there are multiple places in the frontend where
we check a type for both dependency and completeness. So this patch
partially reverts the fix for PR95497, restoring the dependent_type_p
check that guarded the call to is_really_empty_class below.
gcc/cp/ChangeLog:
PR c++/96132
* constexpr.c (potential_constant_expression_1) <case PARM_DECL>:
Restore dependent_type_p check that guarded the call to
is_really_empty_class.
gcc/testsuite/ChangeLog:
PR c++/96132
* g++.dg/template/incomplete12.C: New test.
Diff:
---
gcc/cp/constexpr.c | 1 +
gcc/testsuite/g++.dg/template/incomplete12.C | 9 +++++++++
2 files changed, 10 insertions(+)
diff --git a/gcc/cp/constexpr.c b/gcc/cp/constexpr.c
index ff78ebda2dc..97dcc1b1d10 100644
--- a/gcc/cp/constexpr.c
+++ b/gcc/cp/constexpr.c
@@ -7444,6 +7444,7 @@ potential_constant_expression_1 (tree t, bool want_rval, bool strict, bool now,
{
tree type = TREE_TYPE (t);
if ((processing_template_decl && !COMPLETE_TYPE_P (type))
+ || dependent_type_p (type)
|| is_really_empty_class (type, /*ignore_vptr*/false))
/* An empty class has no data to read. */
return true;
diff --git a/gcc/testsuite/g++.dg/template/incomplete12.C b/gcc/testsuite/g++.dg/template/incomplete12.C
new file mode 100644
index 00000000000..335e5356874
--- /dev/null
+++ b/gcc/testsuite/g++.dg/template/incomplete12.C
@@ -0,0 +1,9 @@
+// PR c++/96132
+// { dg-do compile }
+
+template <int> class a;
+
+template <int b> class c {
+ a<b> e;
+ void operator=(c d) { e = d; }
+};
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-08-22 23:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-22 23:29 [gcc/devel/autopar_devel] c++: Partially revert fix for PR c++/95497 [PR96132] Giuliano Belinassi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).