public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r9-8900] c++: Try to complete decomp types [PR95328] Date: Wed, 16 Sep 2020 19:22:16 +0000 (GMT) [thread overview] Message-ID: <20200916192216.566693951894@sourceware.org> (raw) https://gcc.gnu.org/g:8efa945b308307fd9b0313705f5826a8499de405 commit r9-8900-g8efa945b308307fd9b0313705f5826a8499de405 Author: Jakub Jelinek <jakub@redhat.com> Date: Thu May 28 23:40:54 2020 +0200 c++: Try to complete decomp types [PR95328] Two years ago Paolo has added the else if (processing_template_decl && !COMPLETE_TYPE_P (type)) pedwarn (...); lines into cp_finish_decomp. For type dependent decl we punt much earlier, but even for types which aren't type dependent COMPLETE_TYPE_P might be false as this testcase shows, so this patch tries to complete_type first (the reason for writing it that way is that it is then followed by another else if and if complete_type returns error_mark_node, we shouldn't report anything, as a bug should have been reported already. 2020-05-28 Jakub Jelinek <jakub@redhat.com> PR c++/95328 * decl.c (cp_finish_decomp): Call complete_type before checking COMPLETE_TYPE_P. * g++.dg/cpp1z/decomp53.C: New test. (cherry picked from commit 3d8d5ddb539a5254c7ef83414377f4c74c7701d4) Diff: --- gcc/cp/decl.c | 2 ++ gcc/testsuite/g++.dg/cpp1z/decomp53.C | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c index 6ff9cdf0afe..ec18f87e47f 100644 --- a/gcc/cp/decl.c +++ b/gcc/cp/decl.c @@ -7864,6 +7864,8 @@ cp_finish_decomp (tree decl, tree first, unsigned int count) error_at (loc, "cannot decompose lambda closure type %qT", type); goto error_out; } + else if (processing_template_decl && complete_type (type) == error_mark_node) + goto error_out; else if (processing_template_decl && !COMPLETE_TYPE_P (type)) pedwarn (loc, 0, "structured binding refers to incomplete class type %qT", type); diff --git a/gcc/testsuite/g++.dg/cpp1z/decomp53.C b/gcc/testsuite/g++.dg/cpp1z/decomp53.C new file mode 100644 index 00000000000..b34e6ac7250 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp1z/decomp53.C @@ -0,0 +1,22 @@ +// PR c++/95328 +// { dg-do compile { target c++11 } } +// { dg-options "" } + +template <typename T> +struct S +{ + int a, b; +}; + +template <typename T> +void +foo () +{ + auto [a, b] = S<int>(); // { dg-warning "structured bindings only available with" "" { target c++14_down } } +} + +int +main () +{ + foo<int> (); +}
reply other threads:[~2020-09-16 19:22 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200916192216.566693951894@sourceware.org \ --to=jakub@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).