public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r9-8905] veclower: Don't ICE on .VEC_CONVERT calls with no lhs [PR96426]
@ 2020-09-16 19:22 Jakub Jelinek
0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2020-09-16 19:22 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:3f804f63cde54ff94f35abd00953b050a4c861c7
commit r9-8905-g3f804f63cde54ff94f35abd00953b050a4c861c7
Author: Jakub Jelinek <jakub@redhat.com>
Date: Tue Aug 4 11:33:18 2020 +0200
veclower: Don't ICE on .VEC_CONVERT calls with no lhs [PR96426]
.VEC_CONVERT is a const internal call, so normally if the lhs is not used,
we'd DCE it far before getting to veclower, but with -O0 (or perhaps
-fno-tree-dce and some other -fno-* options) it can happen.
But as the internal fn needs the lhs to know the type to which the
conversion is done (and I think that is a reasonable representation, having
some magic another argument and having to create constants with that type
looks overkill to me), we just should DCE those calls ourselves.
During veclower, we can't really remove insns, as the callers would be
upset, so this just replaces it with a GIMPLE_NOP.
2020-08-04 Jakub Jelinek <jakub@redhat.com>
PR middle-end/96426
* tree-vect-generic.c (expand_vector_conversion): Replace .VEC_CONVERT
call with GIMPLE_NOP if there is no lhs.
* gcc.c-torture/compile/pr96426.c: New test.
(cherry picked from commit 95f5a3258dd8a9584f2b10304f79441ef2d4c64c)
Diff:
---
gcc/testsuite/gcc.c-torture/compile/pr96426.c | 10 ++++++++++
gcc/tree-vect-generic.c | 6 ++++++
2 files changed, 16 insertions(+)
diff --git a/gcc/testsuite/gcc.c-torture/compile/pr96426.c b/gcc/testsuite/gcc.c-torture/compile/pr96426.c
new file mode 100644
index 00000000000..bd573fe5366
--- /dev/null
+++ b/gcc/testsuite/gcc.c-torture/compile/pr96426.c
@@ -0,0 +1,10 @@
+/* PR middle-end/96426 */
+
+typedef long long V __attribute__((vector_size(16)));
+typedef double W __attribute__((vector_size(16)));
+
+void
+foo (V *v)
+{
+ __builtin_convertvector (*v, W);
+}
diff --git a/gcc/tree-vect-generic.c b/gcc/tree-vect-generic.c
index 3e531facf67..1f255fa70c2 100644
--- a/gcc/tree-vect-generic.c
+++ b/gcc/tree-vect-generic.c
@@ -1691,6 +1691,12 @@ expand_vector_conversion (gimple_stmt_iterator *gsi)
gimple *stmt = gsi_stmt (*gsi);
gimple *g;
tree lhs = gimple_call_lhs (stmt);
+ if (lhs == NULL_TREE)
+ {
+ g = gimple_build_nop ();
+ gsi_replace (gsi, g, false);
+ return;
+ }
tree arg = gimple_call_arg (stmt, 0);
tree decl = NULL_TREE;
tree ret_type = TREE_TYPE (lhs);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-16 19:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 19:22 [gcc r9-8905] veclower: Don't ICE on .VEC_CONVERT calls with no lhs [PR96426] Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).