public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/aoliva/heads/testme)] verbosify unified nonconst merges
Date: Thu, 17 Sep 2020 13:46:16 +0000 (GMT)	[thread overview]
Message-ID: <20200917134616.6B48B383F878@sourceware.org> (raw)

https://gcc.gnu.org/g:139b006646d02d6a16d582714b44c897af682702

commit 139b006646d02d6a16d582714b44c897af682702
Author: Alexandre Oliva <oliva@gnu.org>
Date:   Thu Sep 17 09:46:56 2020 -0300

    verbosify unified nonconst merges

Diff:
---
 gcc/fold-const.c | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/gcc/fold-const.c b/gcc/fold-const.c
index c6cffb8ffcf..f901fad51b3 100644
--- a/gcc/fold-const.c
+++ b/gcc/fold-const.c
@@ -6675,6 +6675,20 @@ fold_truth_andor_1 (location_t loc, enum tree_code code, tree truth_type,
       ll_mask = const_binop (BIT_IOR_EXPR, ll_mask, rl_mask);
       lr_mask = const_binop (BIT_IOR_EXPR, lr_mask, rr_mask);
 
+      bool report =
+	!(lnbitsize == rnbitsize
+	  && xll_bitpos == xlr_bitpos
+	  && lnbitpos >= 0
+	  && rnbitpos >= 0)
+	&& !(((ll_bitsize + ll_bitpos == rl_bitpos
+	       && lr_bitsize + lr_bitpos == rr_bitpos)
+	      || (ll_bitpos == rl_bitpos + rl_bitsize
+		  && lr_bitpos == rr_bitpos + rr_bitsize))
+	     && ll_bitpos >= 0
+	     && rl_bitpos >= 0
+	     && lr_bitpos >= 0
+	     && rr_bitpos >= 0);
+
       lhs = make_bit_field_ref (loc, ll_inner, ll_arg,
 				lntype, lnbitsize, lnbitpos,
 				ll_unsignedp || rl_unsignedp, ll_reversep);
@@ -6724,7 +6738,16 @@ fold_truth_andor_1 (location_t loc, enum tree_code code, tree truth_type,
       if (! integer_all_onesp (lr_mask))
 	rhs = build2_loc (loc, BIT_AND_EXPR, type, rhs, lr_mask);
 
-      return build2_loc (loc, wanted_code, truth_type, lhs, rhs);
+      result = build2_loc (loc, wanted_code, truth_type, lhs, rhs);
+
+      if (report)
+	inform (loc, "merged nc extra %qE and %qE into %qE",
+		lhs, rhs, result);
+      else if (l_xor || r_xor)
+	inform (loc, "merged extra %qE and %qE into %qE",
+		lhs, rhs, result);
+
+      return result;
     }
 
   /* Handle the case of comparisons with constants.  If there is something in


             reply	other threads:[~2020-09-17 13:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17 13:46 Alexandre Oliva [this message]
2020-09-23 23:24 Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917134616.6B48B383F878@sourceware.org \
    --to=aoliva@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).