public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r8-10455] explow: Fix ICE caused by plus_constant [PR94002]
@ 2020-09-17 14:24 Jakub Jelinek
0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2020-09-17 14:24 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:3549a5cabdfd4ebb197da99f247d0abad0ba55b5
commit r8-10455-g3549a5cabdfd4ebb197da99f247d0abad0ba55b5
Author: Jakub Jelinek <jakub@redhat.com>
Date: Tue Mar 3 10:42:34 2020 +0100
explow: Fix ICE caused by plus_constant [PR94002]
The following testcase ICEs in cross to riscv64-linux. The problem is
that we have a DImode integral constant (that doesn't fit into SImode),
which is pushed into a constant pool and later access just the first half of
it using a MEM. When plus_constant is called on such a MEM, if the constant
has mode, we verify the mode, but if it doesn't, we don't and ICE later on
when we think the CONST_INT is a valid SImode constant.
2020-03-03 Jakub Jelinek <jakub@redhat.com>
PR rtl-optimization/94002
* explow.c (plus_constant): Punt if cst has VOIDmode and
get_pool_mode is different from mode.
* gcc.dg/pr94002.c: New test.
(cherry picked from commit e913d4f4771e04d4254bf6c0e720fec5e324a898)
Diff:
---
gcc/explow.c | 3 +++
gcc/testsuite/gcc.dg/pr94002.c | 13 +++++++++++++
2 files changed, 16 insertions(+)
diff --git a/gcc/explow.c b/gcc/explow.c
index 72e52703c48..79c781cb390 100644
--- a/gcc/explow.c
+++ b/gcc/explow.c
@@ -129,6 +129,9 @@ plus_constant (machine_mode mode, rtx x, poly_int64 c, bool inplace)
cst = gen_lowpart (mode, cst);
gcc_assert (cst);
}
+ else if (GET_MODE (cst) == VOIDmode
+ && get_pool_mode (XEXP (x, 0)) != mode)
+ break;
if (GET_MODE (cst) == VOIDmode || GET_MODE (cst) == mode)
{
tem = plus_constant (mode, cst, c);
diff --git a/gcc/testsuite/gcc.dg/pr94002.c b/gcc/testsuite/gcc.dg/pr94002.c
new file mode 100644
index 00000000000..05a02f3f15b
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr94002.c
@@ -0,0 +1,13 @@
+/* PR rtl-optimization/94002 */
+/* { dg-do compile } */
+/* { dg-options "-O1 -fno-tree-dce -fno-tree-reassoc" } */
+/* { dg-additional-options "-fPIC" { target fpic } } */
+
+unsigned a, b;
+
+void
+foo (void)
+{
+ __builtin_sub_overflow (b, 44852956282LL, &a);
+ a += ~b;
+}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-17 14:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 14:24 [gcc r8-10455] explow: Fix ICE caused by plus_constant [PR94002] Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).