public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-3654] [omp, ftracer] Remove incorrect suggestion in ignore_bb_p
@ 2020-10-05 12:20 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2020-10-05 12:20 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:fc998c21c2c49e06cd4e548cd0d21ef25c880dbc
commit r11-3654-gfc998c21c2c49e06cd4e548cd0d21ef25c880dbc
Author: Tom de Vries <tdevries@suse.de>
Date: Mon Oct 5 14:03:34 2020 +0200
[omp, ftracer] Remove incorrect suggestion in ignore_bb_p
In commit ab3f4b27abe "[omp, ftracer] Don't duplicate blocks in SIMT region" I
added a comment in ignore_bb_p suggesting a reordering of SIMT_VOTE_ANY and
SIMT_EXIT, which is not possible since VOTE_ANY may have data dependencies to
storage that is deallocated by SIMT_EXIT.
I've now opened a PR (PR97291) to describe the problem the reordering was
intended to fix.
Remove the incorrect suggestion.
gcc/ChangeLog:
2020-10-05 Tom de Vries <tdevries@suse.de>
* tracer.c (ignore_bb_p): Remove incorrect suggestion.
Diff:
---
gcc/tracer.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/gcc/tracer.c b/gcc/tracer.c
index 5e51752d89f..5ee66511f8d 100644
--- a/gcc/tracer.c
+++ b/gcc/tracer.c
@@ -115,10 +115,8 @@ ignore_bb_p (const_basic_block bb)
/* An IFN_GOMP_SIMT_ENTER_ALLOC/IFN_GOMP_SIMT_EXIT call must be
duplicated as part of its group, or not at all.
- The IFN_GOMP_SIMT_VOTE_ANY is currently part of such a group,
- so the same holds there, but it could be argued that the
- IFN_GOMP_SIMT_VOTE_ANY could be generated after that group,
- in which case it could be duplicated. */
+ The IFN_GOMP_SIMT_VOTE_ANY is part of such a group, so the same holds
+ there. */
if (is_gimple_call (g)
&& (gimple_call_internal_p (g, IFN_GOMP_SIMT_ENTER_ALLOC)
|| gimple_call_internal_p (g, IFN_GOMP_SIMT_EXIT)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-05 12:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 12:20 [gcc r11-3654] [omp, ftracer] Remove incorrect suggestion in ignore_bb_p Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).